✨ (device-core): add new reinstallConfiguration consent use case #7771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
live-github-bot
bot
added
desktop
valpinkman
force-pushed
the
feat/new-super-consent
branch
from
4dd910e
to
7029023
Compare
| * @param transport - The transport object used to communicate with the device. | ||
| * @returns A promise that resolves when the consent is granted. | ||
| */ | ||
| export async function reinstallConfiguration( |
There was a problem hiding this comment.
[COULD] I know in the firmware doc it's called REINSTALL_CONFIG but in my opinion it's better to have something more explicit that describes what it actually does, like reinstallConfigurationInit or requestReinstallConfigurationConsent
valpinkman
force-pushed
the
feat/new-super-consent
branch
from
7029023
to
0a71c43
Compare
ofreyssinet-ledger
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Implement new APDU to give consent after an OS update to reinstall the whole config of the device.
This allows us to skip all the user consent for each step (language pack, custom locksceen, apps, and now apps data) and only require one approval before the whole restore flow.
❓ Context
🧐 Checklist for the PR Reviewers