Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix back button lld card #7772

Merged
merged 3 commits into from
Sep 9, 2024
Merged

fix: fix back button lld card #7772

merged 3 commits into from
Sep 9, 2024

Conversation

sarneijim
Copy link
Contributor

@sarneijim sarneijim commented Sep 7, 2024 •
edited
Loading

✅ Checklist

📝 Description

Card back button implementation for LLD

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Sep 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 8, 2024 11:18pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 8, 2024 11:18pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 8, 2024 11:18pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 8, 2024 11:18pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 8, 2024 11:18pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Sep 7, 2024
@sarneijim sarneijim marked this pull request as ready for review September 9, 2024 08:24
@sarneijim sarneijim requested review from a team as code owners September 9, 2024 08:24
mcayuelas-ledger
mcayuelas-ledger approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Hub

sergiubreban
sergiubreban reviewed Sep 9, 2024
View reviewed changes
apps/ledger-live-desktop/src/renderer/components/WebPTXPlayer/TopBar.tsx
localStorage.setItem("last-screen", url.searchParams.get("lastScreen") || "");
localStorage.setItem(
"last-screen",
url.searchParams.get("lastScreen") || url.searchParams.get("flowName") || "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe flowName can take values that are not a valid screen name!

@sarneijim sarneijim merged commit 7b6d676 into develop Sep 9, 2024
37 of 38 checks passed
@sarneijim sarneijim deleted the feature/lld-back-card-btn branch September 9, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiubreban sergiubreban sergiubreban approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@sarneijim sarneijim

Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarneijim @sergiubreban @mcayuelas-ledger