Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: swap button fix #7793

Merged
merged 2 commits into from
Sep 11, 2024
Merged

hotfix: swap button fix #7793

merged 2 commits into from
Sep 11, 2024

Conversation

chrisduma-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fixes View Details button for Swap Live App

❓ Context

Ticket

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@chrisduma-ledger chrisduma-ledger requested a review from a team as a code owner September 11, 2024 12:34
@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 11, 2024 0:34am
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 11, 2024 0:34am
native-ui-storybook ⬜️ Ignored (Inspect) Sep 11, 2024 0:34am
react-ui-storybook ⬜️ Ignored (Inspect) Sep 11, 2024 0:34am
web-tools ⬜️ Ignored (Inspect) Sep 11, 2024 0:34am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 11, 2024
@chrisduma-ledger chrisduma-ledger merged commit 94a33da into release Sep 11, 2024
15 of 19 checks passed
@chrisduma-ledger chrisduma-ledger deleted the hotfix/swap-button branch September 11, 2024 12:35
CremaFR pushed a commit that referenced this pull request Sep 11, 2024
@chrisduma-ledger @CremaFR
Merge pull request #7793 from LedgerHQ/hotfix/swap-button
301ef9c 
hotfix: swap button fix
CremaFR added a commit that referenced this pull request Sep 11, 2024
@CremaFR
Merge pull request #7794 from LedgerHQ/cherrypick/release
4128cce 
Merge pull request #7793 from LedgerHQ/hotfix/swap-button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CremaFR CremaFR CremaFR approved these changes

Assignees

@chrisduma-ledger chrisduma-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisduma-ledger @CremaFR