feat(llm): 🏷️ add memo/tag input in some coins send flow #8155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
live-github-bot
bot
added
mobile
There was a problem hiding this comment.
Is it possible to make one generic MemoTag? like
import React from "react";
import { AnimatedInput } from "@ledgerhq/native-ui";
import { MemoTagInputProps } from "LLM/features/MemoTag/types";
// Make the component generic, accepting a transaction type `T`.
export default function MemoTagInput<T>({ onChange, ...inputProps }: MemoTagInputProps<T>) {
const [value, setValue] = React.useState("");
const handleChange = (text: string) => {
const value = text;
setValue(value);
onChange({
patch: { memo: value || undefined },
isEmpty: !value,
});
};
return <AnimatedInput {...inputProps} value={value} onChangeText={handleChange} />;
}
and then use it in each family ?
import type { Transaction as CardanoTransaction } from "@ledgerhq/live-common/families/cardano/types";
<MemoTagInput<CardanoTransaction>
onChange={handleCardanoChange}
/* other props */
/>;
There was a problem hiding this comment.
Nice one 🙌
It really reduced the boilerplate on every coins
| @@ -146,7 +159,17 @@ export default function SendSelectRecipient({ navigation, route }: Props) { | |||
| setTransaction(bridge.updateTransaction(transaction, {})); | |||
| }, [setTransaction, account, parentAccount, transaction]); | |||
|
|
|||
| const onPressContinue = useCallback(async () => { | |||
| const [memoTagDrawerState, setMemoTagDrawerState] = useState<"INITIAL" | "SHOWING" | "SHOWN">( | |||
| "INITIAL", | |||
There was a problem hiding this comment.
maybe use a dedicated enum or type?
Wozacosta
approved these changes
Oct 22, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Screen.Recording.2024-10-22.at.10.53.12.mov
Add a memo tag input on all coins where it had been implemented on the summary step except Stellar. Stellar will be done on a follow up PR.
List of the coins:
❓ Context
🧐 Checklist for the PR Reviewers