Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA-283][Detox] Improve slack notification #8157

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Oct 21, 2024

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • Detox Slack notification

📝 Description

We want to have the same notficiation as Desktop test for Detox tests

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 3:22pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 3:22pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 3:22pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 3:22pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 3:22pm

@abdurrahman-ledger abdurrahman-ledger merged commit 18c461f into develop Oct 23, 2024
38 of 42 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa_283_detox_improve_slack_notif branch October 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants