-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin LLM + LLD + root dependencies #8158
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
9970287
to
93c7123
Compare
e23b1f6
to
0dc1cba
Compare
0dc1cba
to
ac39867
Compare
Build https://github.com/LedgerHQ/ledger-live/actions/runs/11456967860/job/31876347210?pr=8158 was for just the root package.json, which failed only on test-libraries. @KVNLS has said this is an unrelated problem with libraries that will be fixed today. Expanding this test to include ledger live desktop and mobile |
Desktop Bundle Checks🚀 Mobile Bundle Checks✅ Previous issues have all been fixed. |
cab597c
to
a52a862
Compare
a52a862
to
cd92019
Compare
7fefbc7
to
cd92019
Compare
cd92019
to
8d5b318
Compare
8d5b318
to
ecb14d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📝 Description
Pin dependency versions in all package.json files. This was done by:
pnpm i
on latestdevelop
pnpm list
s the current installed version in that particular directorySee the first commit of the PR for the script (it's removed in a later commit).
Caveats:
/libs/*
(out of scope)@playwright/tests
in LLD - pinning this caused tricky testing issues that I haven't yet found a solution for❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-14476