Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin LLM + LLD + root dependencies #8158

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Conversation

angusbayley
Copy link
Contributor

@angusbayley angusbayley commented Oct 21, 2024

📝 Description

Pin dependency versions in all package.json files. This was done by:

  • running pnpm i on latest develop
  • running a script that, for every dependency listed in every package.json:
    • pnpm lists the current installed version in that particular directory
    • pins that exact version in that package.json

See the first commit of the PR for the script (it's removed in a later commit).

Caveats:

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-14476

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:50am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:50am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:50am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:50am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 8:50am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM tools Has changes in tools cli labels Oct 21, 2024
@angusbayley angusbayley force-pushed the support/pin-package-deps-bisect branch from 9970287 to 93c7123 Compare October 21, 2024 16:06
@angusbayley angusbayley force-pushed the support/pin-package-deps-bisect branch from e23b1f6 to 0dc1cba Compare October 22, 2024 08:43
@live-github-bot live-github-bot bot added common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs labels Oct 22, 2024
@angusbayley angusbayley force-pushed the support/pin-package-deps-bisect branch from 0dc1cba to ac39867 Compare October 22, 2024 09:09
@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli labels Oct 22, 2024
@angusbayley
Copy link
Contributor Author

Build https://github.com/LedgerHQ/ledger-live/actions/runs/11456967860/job/31876347210?pr=8158 was for just the root package.json, which failed only on test-libraries. @KVNLS has said this is an unrelated problem with libraries that will be fixed today. Expanding this test to include ledger live desktop and mobile

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Oct 22, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Oct 22, 2024

Desktop Bundle Checks

Comparing 9862688 against 18c461f.

🚀 semver library is no longer duplicated in main
🚀 @babel/runtime/helpers/extends library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/interopRequireDefault library is no longer duplicated in renderer
🚀 @babel/runtime/regenerator library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/asyncToGenerator library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/possibleConstructorReturn library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/getPrototypeOf library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/extends library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/typeof library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/defineProperty library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/classCallCheck library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/createClass library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/inherits library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/createSuper library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/inheritsLoose library is no longer duplicated in renderer
🚀 @babel/runtime/helpers/esm/assertThisInitialized library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing 9862688 against 18c461f.

✅ Previous issues have all been fixed.

@live-github-bot live-github-bot bot added the ui Has changes in the design system library label Oct 22, 2024
@angusbayley angusbayley force-pushed the support/pin-package-deps-bisect branch from cab597c to a52a862 Compare October 23, 2024 09:09
@live-github-bot live-github-bot bot removed the ui Has changes in the design system library label Oct 23, 2024
@angusbayley angusbayley force-pushed the support/pin-package-deps-bisect branch from a52a862 to cd92019 Compare October 23, 2024 09:12
@live-github-bot live-github-bot bot added the automation CI/CD stuff label Oct 23, 2024
@angusbayley angusbayley force-pushed the support/pin-package-deps-bisect branch from 7fefbc7 to cd92019 Compare October 23, 2024 12:53
@live-github-bot live-github-bot bot removed the automation CI/CD stuff label Oct 23, 2024
@angusbayley angusbayley force-pushed the support/pin-package-deps-bisect branch from cd92019 to 8d5b318 Compare October 23, 2024 12:56
@angusbayley angusbayley marked this pull request as ready for review October 23, 2024 14:00
@angusbayley angusbayley changed the title [DNM] temp: pin all deps except libs Pin LLM + LLD dependencies Oct 23, 2024
@angusbayley angusbayley changed the title Pin LLM + LLD dependencies Pin root + LLM + LLD dependencies Oct 23, 2024
@angusbayley angusbayley changed the title Pin root + LLM + LLD dependencies Pin LLM + LLD + root dependencies Oct 23, 2024
@angusbayley angusbayley force-pushed the support/pin-package-deps-bisect branch from 8d5b318 to ecb14d4 Compare October 24, 2024 08:49
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angusbayley angusbayley merged commit 4f9369a into develop Oct 24, 2024
54 of 56 checks passed
@angusbayley angusbayley deleted the support/pin-package-deps-bisect branch October 24, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants