Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/update tron snap #8160

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Test/update tron snap #8160

merged 2 commits into from
Oct 22, 2024

Conversation

Wozacosta
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Wozacosta Wozacosta self-assigned this Oct 21, 2024
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 4:58pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 4:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 4:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 4:58pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 4:58pm

@live-github-bot live-github-bot bot added the common Has changes in live-common label Oct 21, 2024
@Wozacosta Wozacosta marked this pull request as ready for review October 21, 2024 17:57
@Wozacosta Wozacosta requested a review from a team as a code owner October 21, 2024 17:57
@Wozacosta Wozacosta merged commit fc6a4f9 into develop Oct 22, 2024
58 of 60 checks passed
@Wozacosta Wozacosta deleted the test/update-tron-snap branch October 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants