🚀 Release 2024-10-22

.github/workflows/assigner.yml

@@ -9,6 +9,6 @@ permissions:
 
 jobs:
   assign-author:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: toshimaru/auto-author-assign@v1.4.0

.github/workflows/build-desktop-external-reusable.yml

@@ -19,13 +19,18 @@ jobs:
   build-desktop-app:
     strategy:
       matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest]
-    name: "Build Ledger Live Desktop"
-    runs-on: ${{ matrix.os }}
+        config:
+          [
+            { name: "linux", os: "ubuntu-22.04", image: "linux-x86_64.AppImage" },
+            { name: "win", os: "windows-2022", dotnet: true, image: "win-x64.exe" },
+            { name: "mac", os: "macos-14", image: "mac.dmg" },
+          ]
+    runs-on: ${{ matrix.config.os }}
+    name: "Build LLD (external) | ${{ matrix.config.name }}"
     outputs:
-      linux: ${{ steps.save-result.outputs.ubuntu-latest }}
-      windows: ${{ steps.save-result.outputs.windows-latest }}
-      mac: ${{ steps.save-result.outputs.macos-latest }}
+      linux: ${{ steps.save-result.outputs.linux }}
+      windows: ${{ steps.save-result.outputs.win }}
+      mac: ${{ steps.save-result.outputs.mac }}
     env:
       NODE_OPTIONS: "--max-old-space-size=7168"
     steps:
@@ -35,11 +40,11 @@ jobs:
         with:
           result-encoding: string
           script: |
-            if ("${{ matrix.os }}" === "ubuntu-latest") {
+            if ("${{ matrix.config.name }}" === "linux") {
               return "linux"
-            } else if ("${{ matrix.os }}" === "macos-latest") {
+            } else if ("${{ matrix.config.name }}" === "mac") {
               return "mac"
-            } else if ("${{ matrix.os }}" === "windows-latest") {
+            } else if ("${{ matrix.config.name }}" === "win") {
               return "win"
             }
       - uses: actions/checkout@v4
@@ -52,15 +57,15 @@ jobs:
         uses: LedgerHQ/ledger-live/tools/actions/composites/setup-git-user@develop
       - uses: actions/setup-python@v4
         with:
-          python-version: "3.x"
+          python-version: "3.13.0"
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: 3.3.0
           bundler-cache: true
       - name: Setup the toolchain
         uses: LedgerHQ/ledger-live/tools/actions/composites/setup-toolchain@develop
         with:
-          upgrade_npm: ${{ matrix.os == 'windows-latest' }}
+          upgrade_npm: ${{ matrix.config.name == 'win' }}
       - name: Build desktop
         uses: LedgerHQ/ledger-live/tools/actions/composites/setup-build-desktop@develop
         id: build-desktop
@@ -74,29 +79,16 @@ jobs:
         shell: bash
         if: ${{ !cancelled() }}
         run: |
-          echo "${{matrix.os}}=${{steps.build-app.outcome}}" >> $GITHUB_OUTPUT
-      - name: Upload linux app
-        if: matrix.os == 'ubuntu-latest'
+          echo "${{matrix.config.name}}=${{steps.build-app.outcome}}" >> $GITHUB_OUTPUT
+      - name: Upload app
         uses: actions/upload-artifact@v4
         with:
-          name: ${{ steps.build-desktop.outputs.version }}-linux-x86_64.AppImage
-          path: ${{ github.workspace }}/apps/ledger-live-desktop/dist/${{ steps.build-desktop.outputs.name }}-${{ steps.build-desktop.outputs.version }}-linux-x86_64.AppImage
-      - name: Upload macOS app
-        if: matrix.os == 'macos-latest'
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ steps.build-desktop.outputs.version }}-mac.dmg
-          path: ${{ github.workspace }}/apps/ledger-live-desktop/dist/${{ steps.build-desktop.outputs.name }}-${{ steps.build-desktop.outputs.version }}-mac.dmg
-      - name: Upload windows
-        if: matrix.os == 'windows-latest'
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ steps.build-desktop.outputs.version }}-win-x64.exe
-          path: ${{ github.workspace }}/apps/ledger-live-desktop/dist/${{ steps.build-desktop.outputs.name }}-${{ steps.build-desktop.outputs.version }}-win-x64.exe
+          name: ${{ steps.build-desktop.outputs.version }}-${{ matrix.config.image }}
+          path: ${{ github.workspace }}/apps/ledger-live-desktop/dist/${{ steps.build-desktop.outputs.name }}-${{ steps.build-desktop.outputs.version }}-${{ matrix.config.image }}
 
   report:
     needs: build-desktop-app
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: ${{ !cancelled() && github.event_name == 'workflow_dispatch' }}
     steps:
       - uses: actions/github-script@v7
@@ -116,23 +108,23 @@ jobs:
             });
 
             const findJobUrl = os =>
-              jobs.find(job => job.name == `Build Ledger Live Desktop (${os})`)?.html_url;
+              jobs.find(job => job.name == `Build LLD (external) | ${os}`)?.html_url;
 
             const keys = {
               mac: {
                 symbol: "🍏",
                 name: "macOS",
-                jobUrl: findJobUrl("macos-latest")
+                jobUrl: findJobUrl("mac")
               },
               windows: {
                 symbol: "🪟",
                 name: "Windows",
-                jobUrl: findJobUrl("windows-latest")
+                jobUrl: findJobUrl("win")
               },
               linux: {
                 symbol: "🐧",
                 name: "Linux",
-                jobUrl: findJobUrl("ubuntu-latest")
+                jobUrl: findJobUrl("linux")
               },
             };
 

.github/workflows/build-desktop-reusable.yml

@@ -37,8 +37,8 @@ jobs:
         config:
           [
             { name: "linux", os: "ledger-live-4xlarge", image: "linux-x86_64.AppImage" },
-            { name: "win", os: "windows-latest", dotnet: true, image: "win-x64.exe" },
-            { name: "mac", os: "macos-latest", image: "mac.dmg" },
+            { name: "win", os: "windows-2022", dotnet: true, image: "win-x64.exe" },
+            { name: "mac", os: "macos-14", image: "mac.dmg" },
           ]
     name: "Build LLD | ${{ matrix.config.name }}"
     runs-on: ${{ matrix.config.os }}
@@ -114,7 +114,7 @@ jobs:
 
   report:
     needs: build-desktop-app
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: ${{ !cancelled() && (github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call' || github.event_name == 'pull_request')}}
     steps:
       - uses: actions/checkout@v4

.github/workflows/build-mobile-external-reusable.yml

@@ -82,7 +82,7 @@ jobs:
           path: ${{ github.workspace }}/apps/ledger-live-mobile/android/app/build/outputs/apk/stagingRelease
 
   build-mobile-app-ios:
-    runs-on: macos-latest
+    runs-on: macos-14
     name: "Build Ledger Live Mobile (Mac OS X)"
     env:
       NODE_OPTIONS: "--max-old-space-size=7168"

.github/workflows/build-mobile-reusable.yml

@@ -126,7 +126,7 @@ jobs:
           path: ${{ github.workspace }}/apps/ledger-live-mobile/mobile.metafile.json
 
   report:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     needs: [build-mobile-app-android, build-mobile-app-ios]
     if: ${{ !cancelled() && (github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call' || github.event_name == 'pull_request' ) }}
     steps:

.github/workflows/commitlint.yml

@@ -24,7 +24,7 @@ permissions:
 
 jobs:
   lint-commits:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: Checkout
         uses: actions/checkout@v2
@@ -51,7 +51,7 @@ jobs:
           name: commitlint
           path: ${{ github.workspace }}/commitlint.out
   report:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     needs: [lint-commits]
     if: ${{ !cancelled() }}
     steps:

.github/workflows/labeler.yml

@@ -9,7 +9,7 @@ jobs:
     permissions:
       contents: read
       pull-requests: write
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: generate token
         id: generate-token

.github/workflows/notify-prerelease-translations.yml

@@ -19,7 +19,7 @@ on:
 jobs:
   release-translation-check:
     name: release branch translation check
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: ${{ github.ref_name != 'release' }}
     steps:
       - uses: actions/checkout@v4

.github/workflows/sonar.yml

@@ -0,0 +1,60 @@
+name: "[Code Quality Check] Sonar Scan"
+
+on:
+  workflow_dispatch:
+    inputs:
+        ref:
+          description: "Which (branch or tag) you want to perform a sonar scan ?"
+          required: false
+          default: develop
+  schedule:
+    - cron: "9 19 * * 1-5" # every working day at 7pm we will do a daily scan on develop
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+
+permissions:
+  id-token: write
+  contents: read
+  pull-requests: write
+
+jobs:
+  scan:
+    name: Scan LLM && LLD
+    runs-on: [ledger-live-4xlarge]
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Setup git user
+        uses: LedgerHQ/ledger-live/tools/actions/composites/setup-git-user@develop
+      - name: Setup the caches
+        uses: LedgerHQ/ledger-live/tools/actions/composites/setup-caches@develop
+        id: caches
+        with:
+          skip-turbo-cache: "false"
+          accountId: ${{ secrets.AWS_ACCOUNT_ID_PROD }}
+          roleName: ${{ secrets.AWS_CACHE_ROLE_NAME }}
+          region: ${{ secrets.AWS_CACHE_REGION }}
+          turbo-server-token: ${{ secrets.TURBOREPO_SERVER_TOKEN }}
+      - name: Setup the toolchain
+        uses: LedgerHQ/ledger-live/tools/actions/composites/setup-toolchain@develop
+      - name: Install dependencies
+        env:
+          LANG: en_US.UTF-8
+        run: |
+          pnpm i --filter="ledger-live-desktop..." --filter="ledger-live" --filter="@ledgerhq/dummy-*-app..." --unsafe-perm
+          pnpm i --filter="live-mobile..." --filter="ledger-live" --no-frozen-lockfile --unsafe-perm
+      - name: Build dependencies
+        run: |
+          pnpm build:lld:deps --api="http://127.0.0.1:${{ steps.caches.outputs.port }}" --token="${{ secrets.TURBOREPO_SERVER_TOKEN }}" --team="foo"
+          pnpm build:llm:deps --api="http://127.0.0.1:${{ steps.caches.outputs.port }}" --token="${{ secrets.TURBOREPO_SERVER_TOKEN }}" --team="foo"
+
+      - name: Generate Unit test coverage for LLD & LLM
+        run: |
+          pnpm desktop test:jest:coverage --coverageDirectory=desktop-coverage
+          pnpm mobile test:jest:coverage --coverageDirectory=mobile-coverage
+      - uses: sonarsource/sonarqube-scan-action@master
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+          SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}

.github/workflows/test-desktop-reusable.yml

@@ -34,8 +34,8 @@ jobs:
     env:
       NODE_OPTIONS: "--max-old-space-size=7168"
       FORCE_COLOR: 3
-      CI_OS: ubuntu-latest
-    runs-on: ubuntu-latest
+      CI_OS: ubuntu-22.04
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
         with:
@@ -76,8 +76,8 @@ jobs:
     env:
       NODE_OPTIONS: "--max-old-space-size=7168"
       FORCE_COLOR: 3
-      CI_OS: ubuntu-latest
-    runs-on: ubuntu-latest
+      CI_OS: ubuntu-22.04
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
         with:
@@ -107,7 +107,7 @@ jobs:
       NODE_OPTIONS: "--max-old-space-size=7168"
       INSTRUMENT_BUILD: true
       FORCE_COLOR: 3
-      CI_OS: "ubuntu-latest"
+      CI_OS: "ubuntu-22.04"
       PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
       LC_ALL: en_US.UTF-8
       # DEBUG: "pw:browser*"
@@ -171,7 +171,7 @@ jobs:
           path: apps/ledger-live-desktop/allure-results
   report:
     needs: [codechecks, unit-tests, e2e-tests-linux]
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: ${{ !cancelled() }}
     steps:
       - uses: actions/checkout@v4

.github/workflows/test-libs-reusable.yml

@@ -148,7 +148,7 @@ jobs:
   report:
     needs: [test-docs, test-libraries, codecheck-libraries]
     if: ${{ !cancelled() && github.event_name == 'workflow_dispatch' }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/download-artifact@v4
         with:

.github/workflows/test-mobile-e2e-reusable.yml

@@ -364,7 +364,7 @@ jobs:
 
   report:
     needs: [detox-tests-android, detox-tests-ios]
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: ${{ !cancelled() && (github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call' || github.event_name == 'pull_request') }}
     steps:
       - uses: actions/checkout@v4
@@ -452,7 +452,7 @@ jobs:
           path: ${{ github.workspace }}/summary-detox.json
 
   report-on-slack:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     needs: [detox-tests-android, detox-tests-ios]
     if: ${{ failure() && github.event_name == 'push' }}
     steps:

apps/cli/CHANGELOG.md

@@ -1,5 +1,29 @@
 # @ledgerhq/live-cli
 
+## 24.7.4
+
+### Patch Changes
+
+- Updated dependencies [[`17732b4`](https://github.com/LedgerHQ/ledger-live/commit/17732b4f3c8fbde9c2fcb51079779dad23af72f2), [`d5bbf11`](https://github.com/LedgerHQ/ledger-live/commit/d5bbf11403c740b1e529001a008233b2f19e3418), [`b3746c3`](https://github.com/LedgerHQ/ledger-live/commit/b3746c35af33db0e4a84887d2917511a137218b3), [`65c3322`](https://github.com/LedgerHQ/ledger-live/commit/65c3322bf3871659f078148ab4b5c12b0fd53dc1), [`3d8cd98`](https://github.com/LedgerHQ/ledger-live/commit/3d8cd98486402b69de7e1dcacdfe864f3d135ec9), [`e66d371`](https://github.com/LedgerHQ/ledger-live/commit/e66d3714e5e4fd6a8e3f5980a463b3bb61f40c4b), [`fc6a4f9`](https://github.com/LedgerHQ/ledger-live/commit/fc6a4f93ef3c9101c20e54d8ec6a53e7a86c25f1), [`d6c9096`](https://github.com/LedgerHQ/ledger-live/commit/d6c9096968692b64d12c6bd81e8daa48f55793b9)]:
+  - @ledgerhq/live-common@34.13.0
+  - @ledgerhq/coin-framework@0.18.6
+  - @ledgerhq/coin-bitcoin@0.8.6
+  - @ledgerhq/device-core@0.4.5
+  - @ledgerhq/live-countervalues@0.2.11
+  - @ledgerhq/live-wallet@0.7.3
+
+## 24.7.4-next.0
+
+### Patch Changes
+
+- Updated dependencies [[`17732b4`](https://github.com/LedgerHQ/ledger-live/commit/17732b4f3c8fbde9c2fcb51079779dad23af72f2), [`d5bbf11`](https://github.com/LedgerHQ/ledger-live/commit/d5bbf11403c740b1e529001a008233b2f19e3418), [`b3746c3`](https://github.com/LedgerHQ/ledger-live/commit/b3746c35af33db0e4a84887d2917511a137218b3), [`65c3322`](https://github.com/LedgerHQ/ledger-live/commit/65c3322bf3871659f078148ab4b5c12b0fd53dc1), [`3d8cd98`](https://github.com/LedgerHQ/ledger-live/commit/3d8cd98486402b69de7e1dcacdfe864f3d135ec9), [`e66d371`](https://github.com/LedgerHQ/ledger-live/commit/e66d3714e5e4fd6a8e3f5980a463b3bb61f40c4b), [`fc6a4f9`](https://github.com/LedgerHQ/ledger-live/commit/fc6a4f93ef3c9101c20e54d8ec6a53e7a86c25f1), [`d6c9096`](https://github.com/LedgerHQ/ledger-live/commit/d6c9096968692b64d12c6bd81e8daa48f55793b9)]:
+  - @ledgerhq/live-common@34.13.0-next.0
+  - @ledgerhq/coin-framework@0.18.6-next.0
+  - @ledgerhq/coin-bitcoin@0.8.6-next.0
+  - @ledgerhq/device-core@0.4.5-next.0
+  - @ledgerhq/live-countervalues@0.2.11-next.0
+  - @ledgerhq/live-wallet@0.7.3-next.0
+
 ## 24.7.3
 
 ### Patch Changes

apps/cli/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ledgerhq/live-cli",
-  "version": "24.7.3",
+  "version": "24.7.4",
   "description": "ledger-live CLI version",
   "repository": {
     "type": "git",