feat: 💄 Add new AnimatedInputSelect in DS #8167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mcayuelas-ledger
force-pushed
the
feat/animated-input-select
branch
from
ee21088
to
8cd5640
Compare
| align-items: center; | ||
| width: 100%; | ||
| height: auto; | ||
| padding: 15px 0px 15px 15px; |
There was a problem hiding this comment.
Can we use the spaces from the theme instead of an arbitrary value ? spaces[6] is equal to 16px which is close enough imo
| renderRight={() => ( | ||
| <SelectComponent | ||
| text={text} | ||
| color={theme ? inputStatusColors[inputStatus]({ theme }) : "neutral.c100"} |
There was a problem hiding this comment.
Do we need this condition ? Can useTheme() return a falsy value ?
mcayuelas-ledger
force-pushed
the
feat/animated-input-select
branch
from
8cd5640
to
7258d9a
Compare
thesan
reviewed
Oct 22, 2024
|
|
||
| export const SelectComponent = ({ text, color, onPressSelect }: SelectProps) => { | ||
| return ( | ||
| <Container width={"50%"} color={color}> |
There was a problem hiding this comment.
Why not putting the width: 50% in the Container definition ?
| disabled: false, | ||
| placeholder: "Edit Tag", | ||
| selectProps: { | ||
| onPressSelect: () => console.log("Select"), |
There was a problem hiding this comment.
I think you could use the storybook action here:
import { action } from "@storybook/addon-actions";
...
selectProps: {
onPressSelect: action("Select"),
cgrellard-ledger
previously approved these changes
Oct 22, 2024
mcayuelas-ledger
force-pushed
the
feat/animated-input-select
branch
from
7258d9a
to
44b7a85
Compare
thesan
reviewed
Oct 22, 2024
| disabled: false, | ||
| placeholder: "Edit Tag", | ||
| selectProps: { | ||
| onPressSelect: () => action("Select"), |
There was a problem hiding this comment.
Sorry I was wrong in the initial suggestion. It should be: onPressSelect: action("Select")
mcayuelas-ledger
force-pushed
the
feat/animated-input-select
branch
from
44b7a85
to
10b75ab
Compare
mcayuelas-ledger
force-pushed
the
feat/animated-input-select
branch
from
10b75ab
to
6afb560
Compare
thesan
previously approved these changes
Oct 22, 2024
mcayuelas-ledger
force-pushed
the
feat/animated-input-select
branch
from
6afb560
to
c4889fe
Compare
mcayuelas-ledger
force-pushed
the
feat/animated-input-select
branch
from
c4889fe
to
7b59b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
New component FIgma for MemoTag in LLM
Screen.Recording.2024-10-22.at.14.07.21.mov
❓ Context
🧐 Checklist for the PR Reviewers