🩹 [QAA-304] Adding check for operation history when adding an account #8168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
| @@ -9,14 +9,17 @@ export class PortfolioPage extends AppPage { | |||
| private swapEntryButton = this.page.getByTestId("swap-entry-button"); | |||
| private stakeEntryButton = this.page.getByTestId("stake-entry-button"); | |||
| private chart = this.page.getByTestId("chart-container"); | |||
| private operationList = this.page.locator("id=operation-list"); | |||
There was a problem hiding this comment.
could you replace by #operation-list please?
VicAlbr
force-pushed
the
support/qaa-304
branch
from
8277391
to
842b8ca
Compare
| @@ -50,6 +50,7 @@ for (const currency of currencies) { | |||
| if (currency.currency.name !== Currency.TON.name) { | |||
| await app.layout.expectBalanceVisibility(); | |||
| } | |||
| await app.portfolio.opperationHistory(); | |||
There was a problem hiding this comment.
small typo 2 "p"
| async scrollToOperations() { | ||
| await this.page.waitForTimeout(500); | ||
| const operationList = this.page.locator("id=operation-list"); | ||
| await operationList.scrollIntoViewIfNeeded(); | ||
| } | ||
|
|
||
| @step("check operation history") | ||
| async opperationHistory() { |
There was a problem hiding this comment.
could you rename method to something like checkOperationsHistory please?
| @@ -81,9 +84,24 @@ export class PortfolioPage extends AppPage { | |||
| await assetRowLocator.click(); | |||
| } | |||
|
|
|||
| @step("Scroll to operations") | |||
| async scrollToOperations() { | |||
| await this.page.waitForTimeout(500); | |||
| const operationList = this.page.locator("id=operation-list"); | |||
There was a problem hiding this comment.
might make sense to use this locator
There was a problem hiding this comment.
yes, that's legacy code used for mocked test. I didn't touch it but I can do the update :)
bharamboure-ledger
approved these changes
Oct 22, 2024
LucasWerey
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Adding minor check on Add account
❓ Context
🧐 Checklist for the PR Reviewers