Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish packages that are needed for the cli #8170

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Publish packages that are needed for the cli #8170

merged 1 commit into from
Oct 24, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 22, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

We need to publish the following packages to allow CLI to install from npm.
See issue raised by CS team:https://ledger.slack.com/archives/C8PG210JY/p1728997045300629

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Oct 22, 2024
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 22, 2024 2:21pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 2:21pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 2:21pm
native-ui-storybook ⬜️ Ignored (Inspect) Oct 22, 2024 2:21pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 2:21pm

@KVNLS KVNLS marked this pull request as ready for review October 22, 2024 14:23
@KVNLS KVNLS requested review from a team as code owners October 22, 2024 14:23
@KVNLS KVNLS requested a review from a team October 22, 2024 14:23
@KVNLS KVNLS merged commit 75de49b into develop Oct 24, 2024
58 of 60 checks passed
@KVNLS KVNLS deleted the fix/cli-npm branch October 24, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants