Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-13290][LLM] new device assets/animations #8176

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Oct 23, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • Replaced old lotties by the new ones (except for the Nano onboarding).
  • Adapted the custom lock screen assets to match the new lotties visually.
  • Fixed the typing of animation collections (for onboarding & for device action lotties).

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 2:39pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 2:39pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 2:39pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 2:39pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 25, 2024 2:39pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Oct 23, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Oct 23, 2024

Mobile Bundle Checks

Comparing aa0a2dd against 429072a.

🚀 main.ios.jsbundle bundle size decreased (62.9mb -> 60.5mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (62.9mb -> 60.5mb). Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant