Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lld): localised string in CLS #8177

Conversation

fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Oct 23, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Localised string in CLS LLD

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner October 23, 2024 13:54
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 23, 2024 1:54pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 23, 2024 1:54pm
native-ui-storybook ⬜️ Ignored (Inspect) Oct 23, 2024 1:54pm
react-ui-storybook ⬜️ Ignored (Inspect) Oct 23, 2024 1:54pm
web-tools ⬜️ Ignored (Inspect) Oct 23, 2024 1:54pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Oct 23, 2024
@fAnselmi-Ledger fAnselmi-Ledger merged commit 28c7357 into develop Oct 28, 2024
42 of 47 checks passed
@fAnselmi-Ledger fAnselmi-Ledger deleted the LIVE-12365-lld-rotate-cta-not-translated-on-cls-drawer branch October 28, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants