Use test dataset from cal instead of hardcoded ones #8196
+899
−543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
live-github-bot
bot
added
common
Justkant
reviewed
Oct 29, 2024
| import { getEnv } from "@ledgerhq/live-env"; | ||
| import network from "@ledgerhq/live-network"; | ||
|
|
||
| const CAL_BASE_URL = getEnv("CAL_SERVICE_URL"); |
There was a problem hiding this comment.
Using getEnv like that means that it won't update if changed in the settings dev tools, not a big deal but something to be aware of
There was a problem hiding this comment.
You can change this var via the dev tools?
Justkant
reviewed
Oct 29, 2024
| id: string, | ||
| env: "prod" | "test" = "prod", | ||
| ): Promise<CurrencyData> { | ||
| const { data: currencyData } = await network<CurrencyDataResponse[]>({ |
There was a problem hiding this comment.
It would be interesting to look at integrating typia to validate and type guard the api calls later on
We could just use zod but you still have to declare a schema while with typia you can just use the type as is and get an optimised validator for it at build time
Justkant
previously approved these changes
Oct 29, 2024
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Justkant
approved these changes
Oct 30, 2024
andreicovaciu
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Remove hardcoded values for currencies for test purposes. Instead, leverage CAL service with test flag.
❓ Context
🧐 Checklist for the PR Reviewers