Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mantra integration #8205

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

Canestin
Copy link
Contributor

@Canestin Canestin commented Oct 25, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • add mantra currency

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 2:49pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 2:49pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 2:49pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 2:49pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 2:49pm

Copy link

[Bot] Testing with 'Nitrogen' ✅ 1 txs ($0.00) ⏲ 13.7s

✅ 1 specs are successful: mantra

What is the bot and how does it work? Everything is documented here!

⚠️ 1 spec hints
  • Spec mantra:
    • There are not enough accounts (3) to cover all mutations (6).
      Please increase the account target to at least 7 accounts
Details of the 1 mutations

Spec mantra (3)

Spec mantra found 3 Mantra accounts (preload: 461ms). Will use Cosmos 2.35.24 on nanoS 2.1.0
undefined: 0.1 OM (1ops) (mantra1rs97j43nfyvc689y5rjvnnhrq3tes6ghshzpqh on 44'/118'/0'/0/0) #0 js:2:mantra:mantra1rs97j43nfyvc689y5rjvnnhrq3tes6ghshzpqh:
undefined: 0.01 OM (1ops) (mantra1qvtnzptp30maznnhdg30xl2jtdq2shpnvh0jgp on 44'/118'/1'/0/0) #1 js:2:mantra:mantra1qvtnzptp30maznnhdg30xl2jtdq2shpnvh0jgp:
undefined: 0 OM (0ops) (mantra1vvzwc6l3wfdaqa9rncex8k2uwtpwztswnt8zry on 44'/118'/2'/0/0) #2 js:2:mantra:mantra1vvzwc6l3wfdaqa9rncex8k2uwtpwztswnt8zry:
necessary accounts resynced in 0.23ms
▬ Cosmos 2.35.24 on nanoS 2.1.0
→ FROM undefined: 0.1 OM (1ops) (mantra1rs97j43nfyvc689y5rjvnnhrq3tes6ghshzpqh on 44'/118'/0'/0/0) #0 js:2:mantra:mantra1rs97j43nfyvc689y5rjvnnhrq3tes6ghshzpqh: 0.1 OM spendable. 

max spendable ~0.097789
★ using mutation 'send max'
→ TO undefined: 0.01 OM (1ops) (mantra1qvtnzptp30maznnhdg30xl2jtdq2shpnvh0jgp on 44'/118'/1'/0/0) #1 js:2:mantra:mantra1qvtnzptp30maznnhdg30xl2jtdq2shpnvh0jgp:
✔️ transaction 
SEND MAX
TO mantra1qvtnzptp30maznnhdg30xl2jtdq2shpnvh0jgp

with fees=0.002032
STATUS (1666ms)
  amount: 0.097968 OM
  estimated fees: 0.002032 OM
  total spent: 0.1 OM
errors: 
warnings: 
✔️ has been signed! (3.5s) 
✔️ broadcasted! (153ms) optimistic operation: 
  -0.1 OM            OUT        6181143028D499CF265FAF1331D81CDACA0E01A6BF32D2ED43CC80DB2DB3217A 2024-10-28T10:05
✔️ operation confirmed (0.47ms): 
  -0.1 OM            OUT        6181143028D499CF265FAF1331D81CDACA0E01A6BF32D2ED43CC80DB2DB3217A 2024-10-28T10:05
✔️ undefined: 0.1 OM (1ops) (mantra1rs97j43nfyvc689y5rjvnnhrq3tes6ghshzpqh on 44'/118'/0'/0/0) #0 js:2:mantra:mantra1rs97j43nfyvc689y5rjvnnhrq3tes6ghshzpqh: 0.1 OM spendable. 
✔️ destination operation 
  ? -100000          OUT        6181143028D499CF265FAF1331D81CDACA0E01A6BF32D2ED43CC80DB2DB3217A 2024-10-28T10:05


Details of the 5 uncovered mutations

Spec mantra (5)

  • send some: balance is too low for send (2)
  • delegate new validators: can delegate (1), only one out of 2 accounts is not going to delegate (1)
  • undelegate: balance is too low (2)
  • redelegate: balance is too low for redelegate (2)
  • claim rewards: balance is too low for claim rewards (2)
Portfolio ($0.00) – Details of the 1 currencies
Spec (accounts) State Remaining Runs (est) funds?
mantra (3) 2 ops , 0.11 OM ($0.00) ⚠️ 3 mantra1rs97j43nfyvc689y5rjvnnhrq3tes6ghshzpqh
undefined: 0.1 OM (1ops) (mantra1rs97j43nfyvc689y5rjvnnhrq3tes6ghshzpqh on 44'/118'/0'/0/0) #0 js:2:mantra:mantra1rs97j43nfyvc689y5rjvnnhrq3tes6ghshzpqh:
undefined: 0.01 OM (1ops) (mantra1qvtnzptp30maznnhdg30xl2jtdq2shpnvh0jgp on 44'/118'/1'/0/0) #1 js:2:mantra:mantra1qvtnzptp30maznnhdg30xl2jtdq2shpnvh0jgp:
undefined: 0 OM (0ops) (mantra1vvzwc6l3wfdaqa9rncex8k2uwtpwztswnt8zry on 44'/118'/2'/0/0) #2 js:2:mantra:mantra1vvzwc6l3wfdaqa9rncex8k2uwtpwztswnt8zry:
Performance ⏲ 13.7s

Time spent for each spec: (total across mutations)

Spec (accounts) preload scan re-sync tx status sign op broadcast test destination test
TOTAL 461ms 3.7s 0.53ms 1666ms 3.5s 153ms 0.47ms N/A
mantra (2) 461ms 3.7s 0.53ms 1666ms 3.5s 153ms 0.47ms N/A

What is the bot and how does it work? Everything is documented here!

@Canestin Canestin force-pushed the LIVE-14610-mantra-integration branch from 62379ef to 2727feb Compare October 28, 2024 16:32
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Oct 28, 2024
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Oct 28, 2024
@Canestin Canestin marked this pull request as ready for review October 28, 2024 16:41
@Canestin Canestin requested review from a team as code owners October 28, 2024 16:41
@Canestin Canestin force-pushed the LIVE-14610-mantra-integration branch from 2727feb to ee084c8 Compare October 29, 2024 10:22
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @LedgerHQ/live-hub

@mcayuelas-ledger
Copy link
Contributor

Can you rebase your PR plz ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants