-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π§βπ»(chore) migrate hub scope to knip #8220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
4 Skipped Deployments
|
LucasWerey
changed the title
π§βπ»(lld) migrate to knip
π§βπ»(chore) migrate to knip
Oct 28, 2024
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 12:11
5136c51
to
0971120
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 12:27
0971120
to
c2d1a11
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 12:45
c2d1a11
to
c090e87
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 12:57
c090e87
to
bae9e6c
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 13:44
bae9e6c
to
f4faba4
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 13:57
f4faba4
to
3b5f92f
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 14:00
3b5f92f
to
d8c2da6
Compare
LucasWerey
force-pushed
the
chore/knip
branch
2 times, most recently
from
October 28, 2024 14:48
1669ac0
to
6cf7692
Compare
LucasWerey
changed the title
π§βπ»(chore) migrate to knip
π§βπ»(chore) migrate hub scope to knip
Oct 28, 2024
LucasWerey
force-pushed
the
chore/knip
branch
2 times, most recently
from
October 28, 2024 14:54
88afa2b
to
49eefcf
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 15:09
49eefcf
to
f0bdda2
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 15:25
f0bdda2
to
5fab41a
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 28, 2024 15:44
5fab41a
to
7218df1
Compare
themooneer
reviewed
Oct 29, 2024
themooneer
previously approved these changes
Oct 29, 2024
LucasWerey
force-pushed
the
chore/knip
branch
from
October 29, 2024 10:12
7218df1
to
345d3bd
Compare
LucasWerey
force-pushed
the
chore/knip
branch
2 times, most recently
from
October 29, 2024 14:29
8d357c5
to
341e250
Compare
LucasWerey
force-pushed
the
chore/knip
branch
from
October 29, 2024 14:34
341e250
to
7cd906c
Compare
themooneer
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached. NOT NEEDEDπ Description
Important
MIGRATION FROM UNIMPORTED TO KNIP + Update Code Owners (duplicated and rename trustchain)
this is HUB SCOPE libs/apps only for the moment
the idea is to migrate every projects one by one to knip to have a single config for the whole project. We can still have custom config for each lib if needed
config schema https://unpkg.com/knip@5.30.6/schema.json
config doc : https://knip.dev/reference/configuration
run
pnpm desktop knip-check
knip recommends @types/node but we use deprecated function so we can't use it. Knip still works without
many rules have turned off because idk which one could be useful in our case.
For example there is a lot of unused exports that we could remove. For the moment it's warn only so it doesn't block the CI (and we have a vision on it) but we can remove them in the future and make the rule mandatory
CI test : https://github.com/LedgerHQ/ledger-live/actions/runs/11557213865?pr=8220
e.g LLM :
KNIP Config has been customized to ensure that it remains useful but not overly burdensome :
β Context
π§ Checklist for the PR Reviewers