Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§‘β€πŸ’»(chore) migrate hub scope to knip #8220

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Oct 28, 2024

βœ… Checklist

  • npx changeset was attached. NOT NEEDED
  • Covered by automatic tests.
  • Impact of the changes:
    • Unimported -> Knip on LLD / React-NFT / Live-NFT
    • Proto

πŸ“ Description

Important

MIGRATION FROM UNIMPORTED TO KNIP + Update Code Owners (duplicated and rename trustchain)
this is HUB SCOPE libs/apps only for the moment
the idea is to migrate every projects one by one to knip to have a single config for the whole project. We can still have custom config for each lib if needed

config schema https://unpkg.com/knip@5.30.6/schema.json
config doc : https://knip.dev/reference/configuration

run pnpm desktop knip-check

knip recommends @types/node but we use deprecated function so we can't use it. Knip still works without

many rules have turned off because idk which one could be useful in our case.

For example there is a lot of unused exports that we could remove. For the moment it's warn only so it doesn't block the CI (and we have a vision on it) but we can remove them in the future and make the rule mandatory

CI test : https://github.com/LedgerHQ/ledger-live/actions/runs/11557213865?pr=8220
e.g LLM :
image

KNIP Config has been customized to ensure that it remains useful but not overly burdensome :
image

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner October 28, 2024 10:29
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 29, 2024 2:48pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:48pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:48pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:48pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:48pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD automation CI/CD stuff labels Oct 28, 2024
@LucasWerey LucasWerey changed the title πŸ§‘β€πŸ’»(lld) migrate to knip πŸ§‘β€πŸ’»(chore) migrate to knip Oct 28, 2024
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Oct 28, 2024
@LucasWerey LucasWerey force-pushed the chore/knip branch 2 times, most recently from 1669ac0 to 6cf7692 Compare October 28, 2024 14:48
@LucasWerey LucasWerey changed the title πŸ§‘β€πŸ’»(chore) migrate to knip πŸ§‘β€πŸ’»(chore) migrate hub scope to knip Oct 28, 2024
@LucasWerey LucasWerey force-pushed the chore/knip branch 2 times, most recently from 88afa2b to 49eefcf Compare October 28, 2024 14:54
CODEOWNERS Show resolved Hide resolved
themooneer
themooneer previously approved these changes Oct 29, 2024
@LucasWerey LucasWerey merged commit 272caa9 into develop Oct 31, 2024
53 of 54 checks passed
@LucasWerey LucasWerey deleted the chore/knip branch October 31, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants