Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e swap speculos scenarios: fine- tune error messages checks #8222

Merged

Conversation

bharamboure-ledger
Copy link
Contributor

@bharamboure-ledger bharamboure-ledger commented Oct 28, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes: checking deeper amount related error messages on swaps e2e scenarios

📝 Description

checking deeper amount related error messages on swaps e2e scenarios

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 9:37am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 9:37am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 9:37am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 9:37am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 9:37am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 28, 2024
@bharamboure-ledger bharamboure-ledger force-pushed the support/swap-fine-tune-error-messages-checks branch from 0495a7d to f92e2bd Compare October 29, 2024 09:28
@bharamboure-ledger bharamboure-ledger merged commit f582f13 into develop Oct 30, 2024
45 of 48 checks passed
@bharamboure-ledger bharamboure-ledger deleted the support/swap-fine-tune-error-messages-checks branch October 30, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants