[LLM][PROTECT-3391/3392/3393/3401/3403] Auto redirection to Recover upsell at the end of Stax/Flex onboarding #8226

ofreyssinet-ledger · 2024-10-28T18:35:41Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- Flex/Stax synchronous onboarding:
  - With feature flag recoverUpsellRedirection deactivated, the onboarding flow is unchanged.
  - With feature flag recoverUpsellRedirection activated, the "Backup for your Secret Recovery Phrase" step between Secret Recovery Phrase and Apps Installation will be hidden.
- End of the onboarding:
  - With feature flag recoverUpsellRedirection deactivated, the post onboarding hub is opened immediately.
  - With feature flag recoverUpsellRedirection activate, the Ledger Recover upsell is opened. When that upsell is dismissed, the user is redirected to the post onboarding hub.

How to test:

0. Prerequisite for each test

Reset app (Recover upsell shows only once) OR go to Settings > Debug > Configuration and press "Reset onboarding state".
Go to Settings > Debug > Configuration & enable “Ledger Recover deeplinks environment”. This will ensure the URL Recover upsell is the production one, so it doesn't require any additional local setup (VPN etc.).

Test 1. recoverUpsellRedirection FF enabled
Onboarding Flex / Stax:
-> the "backup" step should not be in the sync onboarding.
-> at the end, it should open the Recover upsell.
-> when dismissing the Recover upsell, it should redirect to post onboarding.

Test 2. recoverUpsellRedirection FF disabled
Onboarding Flex / Stax:
-> the "backup" setup should be in the sync onboarding.
-> at the end, it should open the post onboarding.

Test 3. Nano X onboarding (non reg)
Onboarding Nano X:
-> at the end, it should open the Recover upsell.

Test 4. Nano SP onboarding (non reg)
Onboarding Nano SP:
-> at the end, it should just go to the portfolio screen.

📝 Description

Cf. "impact of the changes".

I had to do some refactoring to have all the post onboarding & upsell auto redirection logic in one place (the portfolio screen) to ensure its robustness for all device models.

❓ Context

JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-10-28T18:35:45Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2024 3:52pm

4 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	Oct 30, 2024 3:52pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Oct 30, 2024 3:52pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Oct 30, 2024 3:52pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Oct 30, 2024 3:52pm

mcayuelas-ledger

Some comments :)

apps/ledger-live-mobile/src/hooks/useAutoRedirectToPostOnboarding/index.ts

...edger-live-mobile/src/hooks/useAutoRedirectToPostOnboarding/useOpenPostOnboardingCallback.ts

...ledger-live-mobile/src/hooks/useAutoRedirectToPostOnboarding/useOpenProtectUpsellCallback.ts

mcayuelas-ledger

LGTM

jdabbech-ledger · 2024-10-30T15:27:40Z

apps/ledger-live-mobile/src/hooks/useAutoRedirectToPostOnboarding/useShouldRedirect.test.ts

+
+function testScenarios(scenarios: Scenario[]) {
+  scenarios.forEach(scenario => {
+    it(`should return ${JSON.stringify(scenario.expected)} for ${JSON.stringify(scenario.device)} and feature flag enabled: ${scenario.featureFlagEnabled}`, () => {


[could] use it.each syntax

…onboarding

Justkant · 2024-10-31T09:56:27Z

apps/ledger-live-mobile/src/hooks/useAutoRedirectToPostOnboarding/index.ts

+  useEffect(() => {
+    if (!isFocused) return;
+    if (shouldRedirectToProtectUpsell) {
+      openProtectUpsell();
+    } else if (shouldRedirectToPostOnboarding && lastConnectedDevice) {
+      openPostOnboarding(lastConnectedDevice.modelId);
+    }
+  }, [
+    lastConnectedDevice,
+    openPostOnboarding,
+    openProtectUpsell,
+    shouldRedirectToPostOnboarding,
+    shouldRedirectToProtectUpsell,
+    focused,
+    isFocused,
+  ]);


I'm wondering if there is a risk of us calling again an open because isFocused toggles when opening the first time and coming back to the screen using this hook

Edit: probably handled here I suppose https://github.com/LedgerHQ/ledger-live/pull/8226/files#diff-3f35818d8304ffbf87ae671eca670437cfc8eade2dfac067406cdb959ae5f496R37-R41

Once the redirection to whatever is done, shouldRedirectToWhatever will be false, so it won't trigger again 👍

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from a909caa to 0037020 Compare October 28, 2024 18:35

github-actions bot assigned ofreyssinet-ledger Oct 28, 2024

live-github-bot bot added mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Oct 28, 2024

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from 0037020 to 4410996 Compare October 28, 2024 18:36

vercel bot had a problem deploying to Preview – web-tools October 28, 2024 18:38 Failure

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from 4410996 to e422f97 Compare October 28, 2024 18:47

vercel bot had a problem deploying to Preview – web-tools October 28, 2024 18:49 Failure

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch 3 times, most recently from 14249d9 to 98b4bb0 Compare October 29, 2024 11:05

ofreyssinet-ledger changed the title ~~Feature/protect 3391 3392 3393 3401 3403~~ [LLM][PROTECT-3391/3392/3393/3401/3403] Auto redirection to Recover upsell at the end of Stax/Flex onboarding Oct 29, 2024

vercel bot deployed to Preview – web-tools October 29, 2024 11:19 View deployment

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch 2 times, most recently from 119771d to 8f59261 Compare October 29, 2024 12:59

vercel bot had a problem deploying to Preview – web-tools October 29, 2024 13:00 Failure

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from 8f59261 to 07016ab Compare October 29, 2024 14:25

vercel bot deployed to Preview – web-tools October 29, 2024 14:32 View deployment

ofreyssinet-ledger marked this pull request as ready for review October 29, 2024 14:45

ofreyssinet-ledger requested review from a team as code owners October 29, 2024 14:45

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from 07016ab to 618e5b5 Compare October 29, 2024 17:07

vercel bot had a problem deploying to Preview – web-tools October 29, 2024 17:08 Failure

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from 618e5b5 to 8a8dae5 Compare October 29, 2024 17:14

vercel bot had a problem deploying to Preview – web-tools October 29, 2024 17:15 Failure

mcayuelas-ledger reviewed Oct 30, 2024

View reviewed changes

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from 8a8dae5 to 9caa863 Compare October 30, 2024 09:21

vercel bot deployed to Preview – web-tools October 30, 2024 09:25 View deployment

ofreyssinet-ledger marked this pull request as draft October 30, 2024 09:45

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from 9caa863 to 46fea4c Compare October 30, 2024 10:11

ofreyssinet-ledger marked this pull request as ready for review October 30, 2024 10:23

vercel bot deployed to Preview – web-tools October 30, 2024 10:23 View deployment

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from 46fea4c to 0cd92dd Compare October 30, 2024 13:20

vercel bot deployed to Preview – web-tools October 30, 2024 13:24 View deployment

mcayuelas-ledger previously approved these changes Oct 30, 2024

View reviewed changes

aussedatlo previously approved these changes Oct 30, 2024

View reviewed changes

jdabbech-ledger previously approved these changes Oct 30, 2024

View reviewed changes

jiyuzhuang and others added 3 commits October 30, 2024 16:47

feat(llc): add recoverUpsellRedirection feature flag

42e27f2

feat(llm): use new recover upsell redirection

739ec4f

feat(llm/post onboarding): auto redirection to Recover upsell & post …

039b446

…onboarding

ofreyssinet-ledger dismissed stale reviews from jdabbech-ledger, aussedatlo, and mcayuelas-ledger via 039b446 October 30, 2024 15:47

ofreyssinet-ledger force-pushed the feature/protect-3391-3392-3393-3401-3403 branch from 0cd92dd to 039b446 Compare October 30, 2024 15:47

vercel bot deployed to Preview – web-tools October 30, 2024 15:51 View deployment

jdabbech-ledger approved these changes Oct 31, 2024

View reviewed changes

Justkant reviewed Oct 31, 2024

View reviewed changes

Justkant approved these changes Oct 31, 2024

View reviewed changes

mcayuelas-ledger approved these changes Oct 31, 2024

View reviewed changes

ofreyssinet-ledger merged commit cd686cf into develop Oct 31, 2024
56 checks passed

ofreyssinet-ledger deleted the feature/protect-3391-3392-3393-3401-3403 branch October 31, 2024 10:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LLM][PROTECT-3391/3392/3393/3401/3403] Auto redirection to Recover upsell at the end of Stax/Flex onboarding #8226

[LLM][PROTECT-3391/3392/3393/3401/3403] Auto redirection to Recover upsell at the end of Stax/Flex onboarding #8226

ofreyssinet-ledger commented Oct 28, 2024 •

edited

Loading

vercel bot commented Oct 28, 2024 •

edited

Loading

mcayuelas-ledger left a comment

mcayuelas-ledger left a comment

jdabbech-ledger Oct 30, 2024

ofreyssinet-ledger Oct 30, 2024

Justkant Oct 31, 2024 •

edited

Loading

ofreyssinet-ledger Oct 31, 2024

[LLM][PROTECT-3391/3392/3393/3401/3403] Auto redirection to Recover upsell at the end of Stax/Flex onboarding #8226

[LLM][PROTECT-3391/3392/3393/3401/3403] Auto redirection to Recover upsell at the end of Stax/Flex onboarding #8226

Conversation

ofreyssinet-ledger commented Oct 28, 2024 • edited Loading

✅ Checklist

How to test:

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Oct 28, 2024 • edited Loading

mcayuelas-ledger left a comment

Choose a reason for hiding this comment

mcayuelas-ledger left a comment

Choose a reason for hiding this comment

jdabbech-ledger Oct 30, 2024

Choose a reason for hiding this comment

ofreyssinet-ledger Oct 30, 2024

Choose a reason for hiding this comment

Justkant Oct 31, 2024 • edited Loading

Choose a reason for hiding this comment

ofreyssinet-ledger Oct 31, 2024

Choose a reason for hiding this comment

ofreyssinet-ledger commented Oct 28, 2024 •

edited

Loading

vercel bot commented Oct 28, 2024 •

edited

Loading

Justkant Oct 31, 2024 •

edited

Loading