Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: swap history for tokens explorer link #8227

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Oct 29, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Issue was for all tokens not only Thorswap. Fixed for every provider

Screenshot 2024-10-29 at 08 33 54 Screenshot 2024-10-29 at 08 33 45

❓ Context

- JIRA or GitHub link:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner October 29, 2024 07:37
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 8:22am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 8:22am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 8:22am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 8:22am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 8:22am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 29, 2024
@CremaFR CremaFR force-pushed the fix/explorer-link-for-tokens-swap branch from a59112b to b64cf9d Compare October 30, 2024 08:21
@CremaFR CremaFR merged commit 22f700c into develop Oct 30, 2024
41 of 42 checks passed
@CremaFR CremaFR deleted the fix/explorer-link-for-tokens-swap branch October 30, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants