Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: thorswap get status send transactionId instead of LL ids #8228

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Oct 29, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Sending correct ids to BE.

❓ Context

- JIRA or GitHub link:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner October 29, 2024 08:16
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 30, 2024 8:26am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 8:26am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 8:26am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 8:26am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 8:26am

@CremaFR CremaFR force-pushed the fix/transaction-id-swap-status branch from d4e3ccf to 93b3b96 Compare October 30, 2024 08:21
@CremaFR CremaFR merged commit 56fa61d into develop Oct 30, 2024
55 of 56 checks passed
@CremaFR CremaFR deleted the fix/transaction-id-swap-status branch October 30, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants