Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Filter in NFT Gallery LLM #8236

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Filter in NFT Gallery LLM were not compatible

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner October 29, 2024 13:33
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 29, 2024 3:10pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:10pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:10pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:10pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 3:10pm

@mcayuelas-ledger mcayuelas-ledger merged commit 52d6621 into develop Oct 30, 2024
53 of 54 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/nfts-filters-in-gallery-llm branch October 30, 2024 07:39
Canestin pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants