Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›(lld): typo + fees url #8239

Merged
merged 1 commit into from
Oct 29, 2024
Merged

πŸ›(lld): typo + fees url #8239

merged 1 commit into from
Oct 29, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Oct 29, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Update typo + url

Screen.Recording.2024-10-29.at.15.24.39.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner October 29, 2024 14:26
@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Oct 29, 2024
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:58pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:58pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 2:58pm

themooneer
themooneer previously approved these changes Oct 29, 2024
@LucasWerey LucasWerey merged commit f63c04f into develop Oct 29, 2024
40 of 42 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-14684 branch October 29, 2024 15:42
Canestin pushed a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants