Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xrp): return 0 as default balance #8242

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

jcchevalier-ledger
Copy link
Member

@jcchevalier-ledger jcchevalier-ledger commented Oct 29, 2024

✅ Checklist

Fix Alpaca balance return 0 when Account has no transaction.
Update Cardano getAccountInfo network call to abstract actNotFound node error.
Add some unit test.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:58pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:58pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:58pm

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
qperrot
qperrot previously approved these changes Oct 30, 2024
@qperrot qperrot requested review from qperrot and removed request for qperrot October 30, 2024 14:58
ComradeAERGO
ComradeAERGO previously approved these changes Oct 30, 2024
Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
@sprohaszka-ledger sprohaszka-ledger merged commit 901cdd5 into develop Oct 30, 2024
54 of 55 checks passed
@sprohaszka-ledger sprohaszka-ledger deleted the fix-coin-module-xrp branch October 30, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants