-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(xrp): return 0 as default balance #8242
Merged
Merged
+253
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
jcchevalier-ledger
force-pushed
the
fix-coin-module-xrp
branch
from
October 29, 2024 16:07
26dc0a3
to
56b8230
Compare
jcchevalier-ledger
force-pushed
the
fix-coin-module-xrp
branch
from
October 29, 2024 16:42
895aff6
to
43f88cb
Compare
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
sprohaszka-ledger
force-pushed
the
fix-coin-module-xrp
branch
from
October 30, 2024 14:45
43f88cb
to
6272dc2
Compare
qperrot
previously approved these changes
Oct 30, 2024
ComradeAERGO
previously approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
sprohaszka-ledger
dismissed stale reviews from ComradeAERGO and qperrot
via
October 30, 2024 15:54
eefb209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Fix Alpaca balance return 0 when Account has no transaction.
Update Cardano
getAccountInfo
network call to abstractactNotFound
node error.Add some unit test.
npx changeset
was attached.📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
❓ Context
🧐 Checklist for the PR Reviewers