Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select placeholder styles in light mode #8245

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: select placeholder styles in light mode #8245

merged 1 commit into from
Oct 29, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 29, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix select placeholder in light mode on LLD.

Before
image

After
Screenshot 2024-10-29 at 17 46 52

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Oct 29, 2024
@KVNLS KVNLS requested a review from a team as a code owner October 29, 2024 16:50
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 29, 2024 4:50pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 29, 2024 4:50pm
native-ui-storybook ⬜️ Ignored (Inspect) Oct 29, 2024 4:50pm
react-ui-storybook ⬜️ Ignored (Inspect) Oct 29, 2024 4:50pm
web-tools ⬜️ Ignored (Inspect) Oct 29, 2024 4:50pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 29, 2024
@KVNLS KVNLS merged commit dd4cb08 into develop Oct 29, 2024
43 checks passed
@KVNLS KVNLS deleted the fix/live-14644 branch October 29, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants