Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap e2e scenarios target appropriate STG env test url #8250

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

bharamboure-ledger
Copy link
Contributor

@bharamboure-ledger bharamboure-ledger commented Oct 30, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Targeting appropriate staging env test url for e2e swap tests to have quotes

❓ Context

quotes aren't loaded, url has changed
/ (ad-hoc fix)


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 30, 2024 11:17am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 30, 2024 11:17am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 30, 2024 11:17am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 30, 2024 11:17am
web-tools ⬜️ Ignored (Inspect) Oct 30, 2024 11:17am

Copy link

@stual-ledger stual-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharamboure-ledger bharamboure-ledger merged commit 732d0d0 into develop Oct 30, 2024
44 of 47 checks passed
@bharamboure-ledger bharamboure-ledger deleted the fix/swap-staging-test-env-url branch October 30, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants