Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LIVE-14547) do not set ptxSwapCoreExperiment as false in analytics #8253

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

Couto
Copy link
Contributor

@Couto Couto commented Oct 30, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

The ptxSwapCoreExperiment could have the following values: false, Demo0, Demo3 or Demo3Thorswap, however, in the segment analytics, the false value makes no sense, by setting as undefined we don't send the flag.

❓ Context

LIVE-14547

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Couto Couto requested a review from a team as a code owner October 30, 2024 15:51
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 30, 2024
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 30, 2024 3:53pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:53pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:53pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:53pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:53pm

@Couto Couto merged commit f2f9a30 into develop Oct 31, 2024
43 of 47 checks passed
@Couto Couto deleted the fix/LIVE-14547-ptxSwapCoreExperiment-analytics branch October 31, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants