Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA] test: 🦺 Adding XRP3 account #8254

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Oct 30, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@VicAlbr VicAlbr marked this pull request as ready for review October 30, 2024 16:01
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 4:02pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 4:02pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 4:02pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 4:02pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 4:02pm

@VicAlbr VicAlbr requested review from a team as code owners October 30, 2024 16:01
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 30, 2024
@VicAlbr VicAlbr merged commit 5b7c59d into develop Oct 30, 2024
42 of 45 checks passed
@VicAlbr VicAlbr deleted the support/adding-xrp-account branch October 30, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants