Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow tracking to be disabled for swap #8256

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Oct 31, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

fixed bug where tracking consent was not passed to swap live app

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner October 31, 2024 08:51
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 31, 2024 8:51am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 31, 2024 8:51am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 31, 2024 8:51am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 31, 2024 8:51am
web-tools ⬜️ Ignored (Inspect) Oct 31, 2024 8:51am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 31, 2024
@CremaFR CremaFR merged commit afecc56 into develop Nov 1, 2024
43 checks passed
@CremaFR CremaFR deleted the fix/swap-share-analytics branch November 1, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants