Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pnpm to v9.12.3 #8262

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Bump pnpm to v9.12.3 #8262

merged 2 commits into from
Oct 31, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 31, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Oct 31, 2024
@live-github-bot live-github-bot bot added the tools Has changes in tools label Oct 31, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:27am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:27am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:27am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:27am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 11:27am

@KVNLS KVNLS requested a review from a team October 31, 2024 12:42
themooneer
themooneer approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVNLS KVNLS merged commit 909d12b into develop Oct 31, 2024
36 checks passed
@KVNLS KVNLS deleted the fix/live-14741 branch October 31, 2024 14:00
KVNLS added a commit that referenced this pull request Oct 31, 2024
@KVNLS
Revert "Merge pull request #8262 from LedgerHQ/fix/live-14741"
5bae808 
This reverts commit 909d12b, reversing
changes made to 3fad47a.
KVNLS added a commit that referenced this pull request Oct 31, 2024
@KVNLS
Merge pull request #8266 from LedgerHQ/fix/revert-pnpm
68a047b 
Revert "Merge pull request #8262 from LedgerHQ/fix/live-14741"
KVNLS added a commit that referenced this pull request Oct 31, 2024
@KVNLS
Revert "Revert "Merge pull request #8262 from LedgerHQ/fix/live-14741""
65508ee 
This reverts commit 5bae808.
KVNLS added a commit that referenced this pull request Oct 31, 2024
@KVNLS
Revert "Revert "Merge pull request #8262 from LedgerHQ/fix/live-14741""
30a1a28 
This reverts commit 5bae808.
KVNLS added a commit that referenced this pull request Oct 31, 2024
@KVNLS
Bump pnpm (#8267)
fc12a76 
* Revert "Revert "Merge pull request #8262 from LedgerHQ/fix/live-14741""

This reverts commit 5bae808.

* fix: package manager version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

Assignees

@KVNLS KVNLS

Labels
tools Has changes in tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KVNLS @themooneer