[QAA] Adding new currencies for e2e send testing #8263
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
| case Currency.BTC: | ||
| deviceLabel = DeviceLabels.CONTINUE; | ||
| break; | ||
| case Currency.DOGE: |
There was a problem hiding this comment.
seems like this case isn't needed
| tx.accountToDebit.currency == Currency.sepETH && | ||
| tx.accountToDebit.currency == Currency.POL && | ||
| tx.accountToDebit.currency == Currency.DOGE && | ||
| tx.accountToDebit.currency == Currency.BCH |
There was a problem hiding this comment.
not sure to understand that condition, you expect currency to be sepETH AND to be POL AND to be DOGE AND to be BCH, correct?
shouldn't it be || ?
There was a problem hiding this comment.
on top of what @bharamboure-ledger says having so many conditions in the "if" seems a bit dirty to be honest
| break; | ||
| case Currency.BTC: | ||
| case Currency.DOGE: |
There was a problem hiding this comment.
is this in use ? there's no instruction in case
VicAlbr
force-pushed
the
support/QAA-313
branch
from
525ceb8
to
f4f0642
Compare
| await pressUntilTextFound(DeviceLabels.ACCEPT); | ||
| await pressBoth(); | ||
| } | ||
|
|
||
| @step("Sign Send Transaction") | ||
| async signSendTransaction(tx: Transaction) { | ||
| const currencyName = tx.accountToDebit.currency; | ||
| switch (currencyName) { | ||
| case Currency.sepETH: |
There was a problem hiding this comment.
is this in use ? there's no instruction in case
| { | ||
| transaction: new Transaction(Account.DOGE_1, Account.DOGE_2, "0.01", Fee.SLOW), | ||
| xrayTicket: "B2CQA-2573", | ||
| }, | ||
| { | ||
| transaction: new Transaction(Account.BCH_1, Account.BCH_2, "0.0001", Fee.SLOW), | ||
| xrayTicket: "2808", |
There was a problem hiding this comment.
you are missing "B2CQA" part of the ticket here and in all lines down below
| @@ -358,7 +358,7 @@ export async function pressBoth() { | |||
|
|
|||
| export async function pressUntilTextFound( | |||
| targetText: string, | |||
| maxAttempts: number = 10, | |||
| maxAttempts: number = 15, | |||
There was a problem hiding this comment.
why was this number increased?
✅ Checklist
npx changesetwas attached.📝 Description
Adding 10 new currencies for e2e send testing:
❓ Context
🧐 Checklist for the PR Reviewers