[DNM] Post-"ghost"-release hotfix workflow #8264
Draft
+101
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
angusbayley
force-pushed
the
support/post-ghost-release-hotfix-workflow
branch
4 times, most recently
from
977ded9
to
5559f90
Compare
angusbayley
changed the title
angusbayley
force-pushed
the
support/post-ghost-release-hotfix-workflow
branch
from
322b8ce
to
23c00a5
Compare
fix: bad var name pull develop, use --since on changeset status fix step name, fetch depth for develop 0 only fetch develop at tag, dont check it out get develop before checking out hotfix git fetch tags first ultra conservative checkout, see if this works
angusbayley
force-pushed
the
support/post-ghost-release-hotfix-workflow
branch
from
23c00a5
to
3ebebec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket here
This PR implements the new hotfix process for targeting arbitrary past releases to issue a hotfix for
Create hotfix branch from any release
This modifies the existing create hotfix workflow to accept parameters for
versionandapplication. Specifying these values allows you to create a hotfix branch at the point of any previous releaseversionis optional, and if unspecified defaults to "latest" - a special keyword that bypasses the tag finding process (see below), instead creating the hotfix branch frommainjust as the workflow did before this PRapplicationis mandatory and is implemented as achoicedropdown with LLM and LLD as the only two optionsIf
versionis specified it is reformatted into a tag using the specifiedapplication, e.g. version2.91.0+LLDwill be reformatted into a the tag for the 2.91.0 release@ledgerhq/live-desktop@2.91.0. This is then used to checkout the repo prior to the remaining hotfix steps.Bonus: the version + application being targeted is appended to the hotfix PR title:
Edge case behaviour:
versionand submits it as empty: it falls back to a ref ofmain(test run)versionis a non-existent version:git fetchfails during the checkout action (test run).Implement new hotfixing process in
release-prepare-hotfixThe PR also:
release-prepare-hotfixworkflowapplicationandtagto target. I don't love this, but haven't thought about a slick and low complexity way to handle this automatically yetmainanddevelopTo confirm, the new process is:
mainordevelop)