Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #8262 from LedgerHQ/fix/live-14741" #8266

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 31, 2024

This reverts commit 909d12b, reversing changes made to 3fad47a.

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

This reverts commit 909d12b, reversing
changes made to 3fad47a.
@KVNLS KVNLS self-assigned this Oct 31, 2024
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ledger-live-github-bot πŸ”„ Building (Inspect) Visit Preview πŸ’¬ Add feedback Oct 31, 2024 2:06pm
native-ui-storybook πŸ”„ Building (Inspect) Visit Preview πŸ’¬ Add feedback Oct 31, 2024 2:06pm
web-tools πŸ”„ Building (Inspect) Visit Preview πŸ’¬ Add feedback Oct 31, 2024 2:06pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 2:06pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 2:06pm

@live-github-bot live-github-bot bot added the tools Has changes in tools label Oct 31, 2024
@KVNLS KVNLS merged commit 68a047b into develop Oct 31, 2024
16 of 23 checks passed
@KVNLS KVNLS deleted the fix/revert-pnpm branch October 31, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant