Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
|
전반적으로 코드 설계는 잘되어있는거 같아서 승인해두겠습니다! |
seokjun01
approved these changes
Jan 7, 2025
dyk-im
reviewed
Jan 8, 2025
src/main/java/com/example/eatmate/app/domain/notice/domain/repository/NoticeRepository.java
Show resolved
Hide resolved
ehs208
requested changes
Jan 8, 2025
src/main/java/com/example/eatmate/app/domain/notice/domain/Notice.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/eatmate/app/domain/notice/service/NoticeService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/eatmate/app/domain/notice/service/NoticeService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/example/eatmate/app/domain/notice/dto/NoticeResponseDto.java
Outdated
Show resolved
Hide resolved
ehs208
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
PR 유형
어떤 변경 사항이 있나요?
다수 공지사항 조회의 경우, 파라미터로 pageNumber 와 pageSize 을 받습니다.
가장 최근 공지사항부터 조회하며,
pageNumber은 0부터 조회할 수 있습니다
pageNumber : (전체 글/pageSize) 개의 페이지 중 원하는 페이지 번호
pageSize : 한 페이지에 포함되는 공지사항의 개수
새로운 기능 추가
버그 수정
CSS 등 사용자 UI 디자인 변경
코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
코드 리팩토링
주석 추가 및 수정
문서 수정
테스트 추가, 테스트 리팩토링
빌드 부분 혹은 패키지 매니저 수정
파일 혹은 폴더명 수정
파일 혹은 폴더 삭제
PR Checklist
PR이 다음 요구 사항을 충족하는지 확인하세요.
📣 To Reviewers