Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Phone shows light theme on dark mode instead of dark theme on dark mode #171

Open
1 task done
1chooo opened this issue Jul 12, 2024 · 2 comments
Open
1 task done
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@1chooo
Copy link

1chooo commented Jul 12, 2024

Description of the bug

I check the icon on my iPhone all the icon is default in the light theme; however, in my laptop it’s default dark theme. Maybe we need to add configuration to make sure the icons display the dark mode successfully when using the mobile phone.

IMG_5237

Steps To Reproduce

  1. Just view in the GitHub Mobile App with the dark theme

Additional Information

No response

Code of Conduct Acknowledgment

  • I have read and agree to the Code of Conduct.
@1chooo 1chooo added the bug Something isn't working label Jul 12, 2024
@1chooo
Copy link
Author

1chooo commented Jul 12, 2024

I also take the screenshot of your homepage, all the icons change into light mode.

IMG_5238

@LelouchFR LelouchFR changed the title [Bug] Icon theme didn’t sync between phone and PC [Bug] Phone shows light theme on dark mode instead of dark theme on dark mode Jul 12, 2024
@LelouchFR
Copy link
Owner

I've been aware of that, but I don't really have an idea of why :/ it may be because of the way that safari is rendering svgs and doesn't really take in count the dark theme and takes everything that is in the css for the theme and parses it as it without media query and shows up the last element changes that are there...

@LelouchFR LelouchFR added the wontfix This will not be worked on label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants