Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed petition_available from logic for defense_rent_pleadings_requ… #561

Merged
merged 1 commit into from
Jun 29, 2024
Merged

removed petition_available from logic for defense_rent_pleadings_requ… #561

merged 1 commit into from
Jun 29, 2024

Conversation

tobyfey
Copy link
Collaborator

@tobyfey tobyfey commented Jun 26, 2024 •
edited
Loading

…irement and defense_lease_not_attached

I don't think defenses should be conditioned on the question "Do you have a copy of the Landlord's Petition available?" There is no other variables that are conditioned on petition_available

fix #560

In this PR, I have:

  • Manually tested to ensure my PR is working
  • Ensured issues that this PR closes will be automatically closed
  • Requested review from Mia or Quinten
  • Ensured automated tests are passing
  • Updated automated tests so they are now passing
  • There were no automated tests on this repo so I filled out this interview and there is now an "it runs" test

@tobyfey tobyfey linked an issue Jun 26, 2024 that may be closed by this pull request
Should whether the pleading is available be part of the logic for defense_rent_pleading_requirements? #285
Closed
@nonprofittechy nonprofittechy merged commit 1538f44 into main Jun 29, 2024
1 check passed
@nonprofittechy nonprofittechy deleted the removepetitionavailablefromlogic branch July 23, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tobyfey @nonprofittechy