-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create edit Student Page #38
Comments
One question, we already have a AdminStudentState class with a StudentSummary property. Should I add the Student property to that class? or there should be another indenpendent State for single students state handling? |
Same state, same reducer. Should we call this property editingStudent ? |
Sounds good to me |
I've started with the Edit Student page and was wondering if we should extract some common functionality I saw in a few screens. My idea is define tabsContainer and tabs components so we can define screens like this: <div>
<h1>{this.props.editStudent.fullname}</h1>
<TabsContainer Selected="Main">
<Tab Title="Main">
<EditStudentForm />
</Tab>
<Tab Title="Trainings">
<EditStudentTrainingsForm />
</Tab>
</TabsContainer>
<br />
<br />
<Link to="/admin/student/list">Back to student list</Link>
<Link to="/admin">Back to Dashboard</Link>
</div> Thoughts? |
Start by implementing the firdt tab only (and with no tabs ui), inclusión the full Cycle, api, validación, fake un memory sabe... @crsanti is working on a tan yo component se can add It later on. |
:) Ok, cool. |
Assigned to @beatrizRG, pending on his confirmation joining the project to properly assign it to him. |
Implement Edit Student Page from Admin module.
Wiki: Admin Edit Student
src/pages/admin/student/edit
.Steps:
Create a fork.
Create new branch called feature/<issue_number>_Create_Training_List_Page (where issue_number is the id of this issue given by Github).
Implement first tab. only UI for now.
Implement tabs component using react-toolbox.
Add form validations.
Implement first tab with functionality (Save).
Implement second tab.
Important: Follow this work flow
The text was updated successfully, but these errors were encountered: