Feature/#68 edit table move field up down

[deletidev]

Fixed #68

[brauliodiez]

MMm.. I think we could write this as:

        <CommandIconButton
          icon={<DownIcon />}
          onClick={() => onMoveDownField(field.id)}
          disabled={fields[fields.length - 1].id !== field.id }
        />

So it would be something like:

-      {fields[fields.length - 1].id !== field.id ? (
        <CommandIconButton
          icon={<DownIcon />}
          onClick={() => onMoveDownField(field.id)}
+       disabled={fields[fields.length - 1].id !== field.id }
        />
-      ) : (
-        <CommandIconButton
-          icon={<DownIcon />}
-          onClick={() => onMoveDownField(field.id)}
-          disabled={true}
-        />
-      )}

[brauliodiez]

And as additional enhancement we can add a small helper function (even could be moved to business and unit tested):

const isLasItemInArray = (fields : FieldVm[], fieldId :  GUID) : boolean =>
  fields[fields.length - 1].id !== fieldId

The the code would be a bit easier to read:

<CommandIconButton
          icon={<DownIcon />}
          onClick={() => onMoveDownField(field.id)}
          disabled={isLasItemInArray(fields, field.id)}
 />

[deletidev]

It's fixed

[brauliodiez]

Similar solution here:

const isFirstItemInArray = (fields : FieldVm[], fieldId :  GUID) : boolean =>
  fields[0].id !== field.id

And in the markup

        <CommandIconButton
          icon={<UpIcon />}
          onClick={() => onMoveUpField(field.id)}
          disabled={isLasItemInArray(fields, field.id)}
        />

[deletidev]

It's fixed