feature/#313 autosave local storage step 1 #350
Conversation
src/core/autosave/autosave.hook.tsx
Outdated
| const { filename, setFilename, setLoadSample } = | ||
| useCanvasViewSettingsContext(); | ||
|
|
||
| const INTERVAL = 6000; |
There was a problem hiding this comment.
Interval should be at least 60000 (60 seconds)
src/core/autosave/autosave.hook.tsx
Outdated
| } | ||
| }; | ||
|
|
||
| return { stopAutosave }; |
There was a problem hiding this comment.
Missing startAutosave stopAutoSave
src/core/autosave/autosave.hook.tsx
Outdated
| const stopAutosave = () => { | ||
| if (timerRef.current) { | ||
| clearInterval(timerRef.current); | ||
| timerRef.current = null; |
There was a problem hiding this comment.
Missing trying to save on close
There was a problem hiding this comment.
Is this possible? what I think is happening is that stopAutosave will be executed when component has already been unmounted, so it doesn't have access to canvasSchema to save it
There was a problem hiding this comment.
That's my doubt, well the provider is created at App level, I think it would be a good idea to give a try and check what happens
There was a problem hiding this comment.
Moved to App level, and still unable to get it to work
src/pods/canvas/canvas.pod.tsx
Outdated
|
|
||
| export const CanvasPod: React.FC = () => { | ||
| const { stopAutosave } = useAutosave(); |
There was a problem hiding this comment.
const { startAutosave, stopAutoSave} = useAutosave();By doing this we have granular control when we start (component mounted) and stop
src/pods/canvas/canvas.pod.tsx
Outdated
|
|
||
| React.useEffect(() => { | ||
| return stopAutosave; | ||
| }, []); |
There was a problem hiding this comment.
React.useEffect(() => {
+ startAutosave();
return stopAutosave;
}, []);
| console.error('File retrieve error', error); | ||
| localStorage.removeItem(key); | ||
| localStorage.setItem( | ||
| 'autoSaveFile', |
There was a problem hiding this comment.
Magic string found, I think we where using a const somewhere?
| filename: '', | ||
| canvasSchema: createDefaultDatabaseSchemaVm(), | ||
| }) | ||
| ); |
There was a problem hiding this comment.
I think we should remove this code here, if it fails because of error on local storage, it will likely again and it can throw another error, rather to swallow on first instance and that's all
…ng the save at catch error
…d schema, when multiple version exist
|
-I can't make the auto save when closing the tab. +Moved |
Closed #313