Create field-accessible and field-list-accessible component in Canvas… #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deletidev
reviewed
Mar 25, 2024
| if (children) | ||
| return <FieldList fieldList={children} listName={`${name} nested`} />; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Change the names of isNN and isChildren to something more descriptive, e.g. handleNN or renderNNElement.
… Accessible-iterations
SkayDks
force-pushed
the
feature/#389-Canvas_Accessible-iterate_over_fields
branch
from
639ad9d
to
8a34885
Compare
deletidev
approved these changes
Mar 26, 2024
brauliodiez
deleted the
feature/#389-Canvas_Accessible-iterate_over_fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Accessible-iterations
Closed #389