Feature/#21 calculate y coordinate on a given table

[deletidev]

No description provided.

[brauliodiez]

Since SeekResult is only going to be used inside this function, we can define the interface just before the SeekFielddeclaration instead of the vm, why this approach? We place in the vms entities that we expect that are going to be used in several files, in this case is rare that this interface could be used outside this file.

+ interface seekResult {
+  found: boolean;
+ parentCollapsed: boolean;
+  YPosition: number;
+ }

const seekField = (

Note you can export in case is needed

[deletidev]

It's fixed

[brauliodiez]

We can remove seekResult from this file

one thing to take into account interfaces should be always uppercase

- export interface seekResult {
+ export interface SeekResult {

[deletidev]

It's fixed

[brauliodiez]

I think we can do the same with this interface as with SeekResult, but we will need to export this interface

[deletidev]

It's fixed

[brauliodiez]

Add a comment:

// If the current node was already collapsed, ignore the child YPosition offset (Opa rulez !)
newYPosition = parentCollapsed ? newYPosition : result.YPosition;

[deletidev]

It's fixed

[brauliodiez]

Since we are just returning a value we can get rid of

- found = true:

And pass found: true in the object it self

[deletidev]

It's fixed

[brauliodiez]

We could create a helper function

const buildFieldFoundResponse = (parentCollapsed: boolean, YPosition: number) => ({
  found: true,
  parentCollapsed,
  YPosition
});

Then we can replace and simplify:

if (field.id === fieldId) {
-      found = true;
- 
-     return {
-        found,
-        parentCollapsed,
-       YPosition: newYPosition,
-    };
+  return buildFieldFoundResponse(parentCollapsed, YNewPosition);
}

[deletidev]

It's fixed

[brauliodiez]

Let's reduce the cyclomatic complexity (Hadouken)

Let's create a helped method:

const addFieldRowHeight = (YPosition : number, parentCollapsed : boolean) : number => (!parentColapsed) newYPosition + ROW_HEIGHT : newYPosition;

Then in this code:

   } else {
+    newYPosition = addFieldRowHeight(newYPosition, parentCollapsed);
-      if (!parentCollapsed) {
-        newYPosition += ROW_HEIGHT;
-      }

[deletidev]

It's fixed

[brauliodiez]

Same thing her we could create a helper

const isParentCollapsedOrCurrentNodeCollapsed = (parentCollapsed : boolean, currentFieldCollapsed : boolean) => (!parentCollapsed && field.isCollapsed) true : parentCollapsed;

+ const parentCollapsed = isParentOrCurrentNodeCollapsed(parentCollapsed, field.isCollapsed);
- if (!parentCollapsed && field.isCollapsed) {
-        parentCollapsed = true;
- }

[deletidev]

It's fixed

[brauliodiez]

This if statement is complex, we can wrap it into a helper function, something like:

const doesFieldContainsChildren = (field: Field) => (field.type === 'object' && field.children &&  field.children.length > 0); 

Then the if statement gets simplified and just by reading the name of the function we know what it does:

     if (
+       doesFieldContainsChildren(field);
-        field.type === 'object' &&
-        field.children &&
-        field.children.length > 0
     ) {

[deletidev]

It's fixed

[brauliodiez]

Here we could make use of buildFieldFoundResponse that we created before

[deletidev]

It's fixed