Test ( #75): added test for edit-table.business / removeField function #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brauliodiez
reviewed
Jan 12, 2024
| y: 0, | ||
| }; | ||
|
|
||
| describe('edit table - removeField function', () => { |
There was a problem hiding this comment.
Add an edge case, what happens if you try to remove a field Id that doesn't exists, in this case it should return exactly the same collection
There was a problem hiding this comment.
Could that be included in the last case?
AlbertoSSC
commented
Jan 12, 2024
| false | ||
| ); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Wouldn't it be enough with this case down here? ('should not remove any field')
…esting to recursive function removeFieldRecursive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #75