Feature/#287 image aspect ratio #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added adjustSizeKeepingAspectRatio function in image.utils.ts
Now if you upload an image (no matter drop, double click or property option) and it is smaller than the defined shapeSizeRestriction, it will adjust to that smaller size.
If you try to upload a larger image for the first time, it will be set to the shapeSizeRestriction, or it will be set to the current size of the component image in case it has been modified.
Also, the image can only be scaled with the 4-corner transformer type, so it cannot adopt another AspectRatio at the moment.