Develop to Main

.golangci.yml

@@ -2,30 +2,19 @@ linters:
   enable:
     - bodyclose
     - gocognit
-    - goconst
     - depguard
     - dogsled
     - dupword # Detects duplicate words.
     - durationcheck
     - errchkjson
-    - exportloopref # Detects pointers to enclosing loop variables.
-    - gocritic # Metalinter; detects bugs, performance, and styling issues.
     - gocyclo
-    - gofumpt # Detects whether code was gofumpt-ed.
-    - goimports
-    - gosec # Detects security problems.
-    - gosimple
     - loggercheck
-    - govet
-    # - golint
     - ineffassign
-    - megacheck
     - wsl
     - misspell # Detects commonly misspelled English words in comments.
     - nakedret
     - nilerr # Detects code that returns nil even if it checks that the error is not nil.
     - nolintlint # Detects ill-formed or insufficient nolint directives.
-    - perfsprint # Detects fmt.Sprintf uses that can be replaced with a faster alternative.
     - prealloc # Detects slice declarations that could potentially be pre-allocated.
     - predeclared # Detects code that shadows one of Go's predeclared identifiers
     - reassign
@@ -34,12 +23,10 @@ linters:
     - tenv # Detects using os.Setenv instead of t.Setenv.
     - thelper # Detects test helpers without t.Helper().
     - tparallel # Detects inappropriate usage of t.Parallel().
-    - typecheck
     - unconvert # Detects unnecessary type conversions.
     - unparam
     - unused
     - usestdlibvars
-    - vet
     - wastedassign
     - errcheck
 

CHANGELOG.md

@@ -1,3 +1,79 @@
+## [1.19.0-beta.7](https://github.com/LerianStudio/midaz/compare/v1.19.0-beta.6...v1.19.0-beta.7) (2024-10-18)
+
+
+### Features
+
+* adds UUID handler for routes with path parameters :sparkles: ([6153896](https://github.com/LerianStudio/midaz/commit/6153896bc83e0d3048a7223f89eafe6b6f2deae3))
+* adds validation error for invalid path parameters :sparkles: ([270ecfd](https://github.com/LerianStudio/midaz/commit/270ecfdc7aa14040aefa29ab09710aa6274acce9))
+* implements handler for parsing UUID path parameters :sparkles: ([6baa571](https://github.com/LerianStudio/midaz/commit/6baa571275c876ab48760f882e48a400bd892196))
+
+
+### Bug Fixes
+
+* better formatting for error message :bug: ([d7135ff](https://github.com/LerianStudio/midaz/commit/d7135ff90f50f154a95928829142a37226be7629))
+* remove asset_code validation on account :bug: ([05b89c5](https://github.com/LerianStudio/midaz/commit/05b89c52266d1e067ffc429d29405d49f50762dc))
+* uses parsed uuid while creating asset :bug: ([333bf49](https://github.com/LerianStudio/midaz/commit/333bf4921d3f2fd48156ead07ac8b1b29d88d5fa))
+* uses parsed uuid while deleting ledger by id :bug: ([8dc3a97](https://github.com/LerianStudio/midaz/commit/8dc3a97f8c859a6948cad099cd61888c8c016bee))
+* uses parsed uuid while deleting organization :bug: ([866170a](https://github.com/LerianStudio/midaz/commit/866170a1d2bb849fc1ed002a9aed99d7ee43eecb))
+* uses parsed uuid while getting all organization ledgers :bug: ([2260a33](https://github.com/LerianStudio/midaz/commit/2260a331e381d452bcab942f9f06864c60444f52))
+* uses parsed uuid while getting and updating a ledger :bug: ([ad1bcae](https://github.com/LerianStudio/midaz/commit/ad1bcae482d2939c8e828b169b566d3a13be95cd))
+* uses parsed uuid while retrieving all assets from a ledger :bug: ([aadf885](https://github.com/LerianStudio/midaz/commit/aadf8852154726bd4aef2e3295221b5472236ed9))
+* uses parsed uuid while retrieving and updating asset :bug: ([9c8b3a2](https://github.com/LerianStudio/midaz/commit/9c8b3a2f9747117e5149f3a515c8a5b582db4942))
+* uses parsed uuid while retrieving organization :bug: ([e2d2848](https://github.com/LerianStudio/midaz/commit/e2d284808c9c1d95d3d1192be2e4ba3e613318dc))
+* uses UUID to find asset :bug: ([381ba21](https://github.com/LerianStudio/midaz/commit/381ba2178633863f17cffb327a7ab2276926ce0d))
+
+## [1.19.0-beta.6](https://github.com/LerianStudio/midaz/compare/v1.19.0-beta.5...v1.19.0-beta.6) (2024-10-18)
+
+
+### Bug Fixes
+
+* asset validate create before to ledger_id :bug: ([da0a22a](https://github.com/LerianStudio/midaz/commit/da0a22a38f57c6d8217e8511abb07592523c822f))
+
+## [1.19.0-beta.5](https://github.com/LerianStudio/midaz/compare/v1.19.0-beta.4...v1.19.0-beta.5) (2024-10-18)
+
+
+### Features
+
+* require code :sparkles: ([40d1bbd](https://github.com/LerianStudio/midaz/commit/40d1bbd7f54c85aaab279e36754274df93d12a34))
+
+## [1.19.0-beta.4](https://github.com/LerianStudio/midaz/compare/v1.19.0-beta.3...v1.19.0-beta.4) (2024-10-18)
+
+
+### Bug Fixes
+
+* add log; :bug: ([3a71282](https://github.com/LerianStudio/midaz/commit/3a712820a16ede4cd50cdc1729c5abf0507950b0))
+* add parentheses on find name or asset query; :bug: ([9b71d2e](https://github.com/LerianStudio/midaz/commit/9b71d2ee9bafba37b0eb9e1a0f328b5d10036d1e))
+* add required in asset_code; :bug: ([d2481eb](https://github.com/LerianStudio/midaz/commit/d2481ebf4d3007df5337394c151360aca28ee69a))
+* adjust to validate if exists code on assets; :bug: ([583890a](https://github.com/LerianStudio/midaz/commit/583890a6c1d178b95b41666a91600a60d3053123))
+* create validation on code to certify that asset_code exist on assets before insert in accounts; :bug: ([2375963](https://github.com/LerianStudio/midaz/commit/2375963e26657972f22ac714c905775bdf0ed5d5))
+* go sec and lint; :bug: ([4d22c8c](https://github.com/LerianStudio/midaz/commit/4d22c8c5be0f6498c5305ed01e1121efbe4e8987))
+* remove copyloopvar and perfsprint; :bug: ([a181709](https://github.com/LerianStudio/midaz/commit/a1817091640de24bad22e43eaddccd86b21dcf82))
+* remove goconst :bug: ([707be65](https://github.com/LerianStudio/midaz/commit/707be656984aaea2c839be70f6c7c17e84375866))
+* remove unique constraint on database in code and reference on accounts; :bug: ([926ca9b](https://github.com/LerianStudio/midaz/commit/926ca9b758d7e69611afa903c035fa01218b108f))
+
+## [1.19.0-beta.3](https://github.com/LerianStudio/midaz/compare/v1.19.0-beta.2...v1.19.0-beta.3) (2024-10-18)
+
+
+### Bug Fixes
+
+* Invalid code format validation :bug: ([e8383ca](https://github.com/LerianStudio/midaz/commit/e8383cac7957d1f0d63ce20f71534052ab1e8703))
+* Invalid code format validation :bug: ([4dfe76c](https://github.com/LerianStudio/midaz/commit/4dfe76c1092412a129a60b09d408f71d8a59dca0))
+
+## [1.19.0-beta.2](https://github.com/LerianStudio/midaz/compare/v1.19.0-beta.1...v1.19.0-beta.2) (2024-10-17)
+
+## [1.19.0-beta.1](https://github.com/LerianStudio/midaz/compare/v1.18.0...v1.19.0-beta.1) (2024-10-17)
+
+
+### Features
+
+* implement get operation by portfolio :sparkles: ([1e9322f](https://github.com/LerianStudio/midaz/commit/1e9322f8257672d95d850739609af87c673d7b56))
+* initialize CLI with root and version commands :sparkles: ([6ebff8a](https://github.com/LerianStudio/midaz/commit/6ebff8a40ba097b0eaa4feb1106ebc29a5ba84dc))
+
+
+### Bug Fixes
+
+* resolve conflicts :bug: ([bc4b697](https://github.com/LerianStudio/midaz/commit/bc4b697c2e50cd1ec3cd41e0f96cb933a17b6a79))
+
 ## [1.18.0](https://github.com/LerianStudio/midaz/compare/v1.17.0...v1.18.0) (2024-10-16)
 
 

Makefile

@@ -72,4 +72,4 @@ transaction:
 all-services:
 	$(MAKE) -C $(AUTH_DIR) $(COMMAND) && \
 	$(MAKE) -C $(LEDGER_DIR) $(COMMAND) && \
-	$(MAKE) -C $(TRANSACTION_DIR) $(COMMAND)
+	$(MAKE) -C $(TRANSACTION_DIR) $(COMMAND)

common/constant/errors.go

@@ -72,4 +72,5 @@ var (
 	ErrNoAccountIDsProvided                = errors.New("0062")
 	ErrFailedToRetrieveAccountsByAliases   = errors.New("0063")
 	ErrNoAccountsFound                     = errors.New("0064")
+	ErrInvalidPathParameter                = errors.New("0065")
 )

common/errors.go

@@ -685,6 +685,12 @@ func ValidateBusinessError(err error, entityType string, args ...any) error {
 			Title:      "No Accounts Found",
 			Message:    "No accounts were found in the search. Please review the search criteria and try again.",
 		},
+		cn.ErrInvalidPathParameter: ValidationError{
+			EntityType: entityType,
+			Code:       cn.ErrInvalidPathParameter.Error(),
+			Title:      "Invalid Path Parameter",
+			Message:    fmt.Sprintf("The provided path parameter(s) %s is/are not in the expected format. Please ensure the parameter adheres to the required format and try again.", args),
+		},
 	}
 
 	if mappedError, found := errorMap[err]; found {

common/net/http/withBody.go

@@ -6,6 +6,9 @@ import (
 	"reflect"
 	"strings"
 
+	cn "github.com/LerianStudio/midaz/common/constant"
+	"github.com/google/uuid"
+
 	"github.com/LerianStudio/midaz/common"
 
 	"github.com/gofiber/fiber/v2"
@@ -152,6 +155,30 @@ func ValidateStruct(s any) error {
 	return nil
 }
 
+// ParseUUIDPathParameters globally, considering all path parameters are UUIDs
+func ParseUUIDPathParameters(c *fiber.Ctx) error {
+	params := c.AllParams()
+
+	var invalidUUIDs []string
+
+	for param, value := range params {
+		parsedUUID, err := uuid.Parse(value)
+		if err != nil {
+			invalidUUIDs = append(invalidUUIDs, param)
+			continue
+		}
+
+		c.Locals(param, parsedUUID)
+	}
+
+	if len(invalidUUIDs) > 0 {
+		err := common.ValidateBusinessError(cn.ErrInvalidPathParameter, "", strings.Join(invalidUUIDs, ", "))
+		return WithError(c, err)
+	}
+
+	return c.Next()
+}
+
 //nolint:ireturn
 func newValidator() (*validator.Validate, ut.Translator) {
 	locale := en.New()

common/net/http/withBody_test.go

@@ -3,6 +3,9 @@ package http
 import (
 	"encoding/json"
 	"github.com/LerianStudio/midaz/common"
+	"github.com/gofiber/fiber/v2"
+	"github.com/stretchr/testify/require"
+	"net/http/httptest"
 	"reflect"
 	"testing"
 )
@@ -76,3 +79,65 @@ func TestFilterRequiredFieldWithNoFields(t *testing.T) {
 		t.Errorf("Want %v, got %v", expected, result)
 	}
 }
+
+func TestParseUUIDPathParameters_ValidUUID(t *testing.T) {
+	app := fiber.New()
+
+	app.Get("/v1/organizations/:id", ParseUUIDPathParameters, func(c *fiber.Ctx) error {
+		return c.SendStatus(fiber.StatusOK) // Se o middleware passar, responde com 200
+	})
+
+	req := httptest.NewRequest("GET", "/v1/organizations/123e4567-e89b-12d3-a456-426614174000", nil)
+	resp, err := app.Test(req, -1)
+	require.NoError(t, err)
+
+	require.Equal(t, fiber.StatusOK, resp.StatusCode)
+}
+
+func TestParseUUIDPathParameters_MultipleValidUUID(t *testing.T) {
+	app := fiber.New()
+
+	app.Get("/v1/organizations/:organization_id/ledgers/:id", ParseUUIDPathParameters, func(c *fiber.Ctx) error {
+		return c.SendStatus(fiber.StatusOK)
+	})
+
+	req := httptest.NewRequest(
+		"GET",
+		"/v1/organizations/123e4567-e89b-12d3-a456-426614174000/ledgers/c71ab589-cf46-4f2d-b6ef-b395c9a475da",
+		nil)
+	resp, err := app.Test(req, -1)
+	require.NoError(t, err)
+
+	require.Equal(t, fiber.StatusOK, resp.StatusCode)
+}
+
+func TestParseUUIDPathParameters_InvalidUUID(t *testing.T) {
+	app := fiber.New()
+
+	app.Get("/v1/organizations/:id", ParseUUIDPathParameters, func(c *fiber.Ctx) error {
+		return c.SendStatus(fiber.StatusOK)
+	})
+
+	req := httptest.NewRequest("GET", "/v1/organizations/invalid-uuid", nil)
+	resp, err := app.Test(req, -1)
+	require.NoError(t, err)
+
+	require.Equal(t, fiber.StatusBadRequest, resp.StatusCode)
+}
+
+func TestParseUUIDPathParameters_ValidAndInvalidUUID(t *testing.T) {
+	app := fiber.New()
+
+	app.Get("/v1/organizations/:organization_id/ledgers/:id", ParseUUIDPathParameters, func(c *fiber.Ctx) error {
+		return c.SendStatus(fiber.StatusOK)
+	})
+
+	req := httptest.NewRequest(
+		"GET",
+		"/v1/organizations/123e4567-e89b-12d3-a456-426614174000/ledgers/invalid-uuid",
+		nil)
+	resp, err := app.Test(req, -1)
+	require.NoError(t, err)
+
+	require.Equal(t, fiber.StatusBadRequest, resp.StatusCode)
+}

common/utils.go

@@ -100,7 +100,9 @@ func ValidateCurrency(code string) error {
 	}
 
 	for _, r := range code {
-		if unicode.IsLetter(r) && !unicode.IsUpper(r) {
+		if !unicode.IsLetter(r) {
+			return cn.ErrInvalidCodeFormat
+		} else if !unicode.IsUpper(r) {
 			return cn.ErrCodeUppercaseRequirement
 		}
 	}

components/ledger/internal/adapters/database/postgres/asset.postgresql.go

@@ -93,7 +93,7 @@ func (r *AssetPostgreSQLRepository) FindByNameOrCode(ctx context.Context, organi
 		return false, err
 	}
 
-	rows, err := db.QueryContext(ctx, "SELECT * FROM asset WHERE organization_id = $1 AND ledger_id = $2 AND name LIKE $3 OR code = $4 AND deleted_at IS NULL ORDER BY created_at DESC",
+	rows, err := db.QueryContext(ctx, "SELECT * FROM asset WHERE organization_id = $1 AND ledger_id = $2 AND (name LIKE $3 OR code = $4) AND deleted_at IS NULL ORDER BY created_at DESC",
 		organizationID, ledgerID, name, code)
 	if err != nil {
 		return false, err

components/ledger/internal/adapters/database/postgres/organization.postgresql.go

@@ -180,7 +180,7 @@ func (r *OrganizationPostgreSQLRepository) Find(ctx context.Context, id uuid.UUI
 
 	var address string
 
-	row := db.QueryRowContext(ctx, `SELECT * FROM organization WHERE id = $1 AND deleted_at IS NULL`, id)
+	row := db.QueryRowContext(ctx, `SELECT * FROM organization WHERE id = $1`, id)
 	if err := row.Scan(&organization.ID, &organization.ParentOrganizationID, &organization.LegalName,
 		&organization.DoingBusinessAs, &organization.LegalDocument, &address, &organization.Status, &organization.StatusDescription,
 		&organization.CreatedAt, &organization.UpdatedAt, &organization.DeletedAt); err != nil {

components/ledger/internal/app/command/create-account.go

@@ -15,18 +15,14 @@ import (
 )
 
 // CreateAccount creates a new account persists data in the repository.
-func (uc *UseCase) CreateAccount(ctx context.Context, organizationID, ledgerID, portfolioID string, cai *a.CreateAccountInput) (*a.Account, error) {
+func (uc *UseCase) CreateAccount(ctx context.Context, organizationID, ledgerID, portfolioID uuid.UUID, cai *a.CreateAccountInput) (*a.Account, error) {
 	logger := mlog.NewLoggerFromContext(ctx)
 	logger.Infof("Trying to create account: %v", cai)
 
 	if common.IsNilOrEmpty(&cai.Name) {
 		cai.Name = cai.AssetCode + " " + cai.Type + " account"
 	}
 
-	if common.IsNilOrEmpty(cai.Alias) {
-		cai.Alias = nil
-	}
-
 	var status a.Status
 	if cai.Status.IsEmpty() {
 		status = a.Status{
@@ -46,8 +42,13 @@ func (uc *UseCase) CreateAccount(ctx context.Context, organizationID, ledgerID,
 		Scale:     &balanceValue,
 	}
 
+	isAsset, _ := uc.AssetRepo.FindByNameOrCode(ctx, organizationID, ledgerID, "", cai.AssetCode)
+	if !isAsset {
+		return nil, common.ValidateBusinessError(cn.ErrAssetCodeNotFound, reflect.TypeOf(a.Account{}).Name())
+	}
+
 	if cai.EntityID == nil {
-		portfolio, err := uc.PortfolioRepo.Find(ctx, uuid.MustParse(organizationID), uuid.MustParse(ledgerID), uuid.MustParse(portfolioID))
+		portfolio, err := uc.PortfolioRepo.Find(ctx, organizationID, ledgerID, portfolioID)
 		if err != nil {
 			logger.Errorf("Error find portfolio to get Entity ID: %v", err)
 			return nil, err
@@ -57,7 +58,7 @@ func (uc *UseCase) CreateAccount(ctx context.Context, organizationID, ledgerID,
 	}
 
 	if !common.IsNilOrEmpty(cai.ParentAccountID) {
-		acc, err := uc.AccountRepo.Find(ctx, uuid.MustParse(organizationID), uuid.MustParse(ledgerID), uuid.MustParse(portfolioID), uuid.MustParse(*cai.ParentAccountID))
+		acc, err := uc.AccountRepo.Find(ctx, organizationID, ledgerID, portfolioID, uuid.MustParse(*cai.ParentAccountID))
 		if err != nil {
 			return nil, err
 		}
@@ -68,7 +69,7 @@ func (uc *UseCase) CreateAccount(ctx context.Context, organizationID, ledgerID,
 	}
 
 	if !common.IsNilOrEmpty(cai.Alias) {
-		_, err := uc.AccountRepo.FindByAlias(ctx, uuid.MustParse(organizationID), uuid.MustParse(ledgerID), uuid.MustParse(portfolioID), *cai.Alias)
+		_, err := uc.AccountRepo.FindByAlias(ctx, organizationID, ledgerID, portfolioID, *cai.Alias)
 		if err != nil {
 			return nil, err
 		}
@@ -82,9 +83,9 @@ func (uc *UseCase) CreateAccount(ctx context.Context, organizationID, ledgerID,
 		Type:            cai.Type,
 		ParentAccountID: cai.ParentAccountID,
 		ProductID:       cai.ProductID,
-		OrganizationID:  organizationID,
-		PortfolioID:     portfolioID,
-		LedgerID:        ledgerID,
+		OrganizationID:  organizationID.String(),
+		PortfolioID:     portfolioID.String(),
+		LedgerID:        ledgerID.String(),
 		EntityID:        *cai.EntityID,
 		Balance:         balance,
 		Status:          status,

components/ledger/internal/app/command/create-product.go

@@ -13,7 +13,7 @@ import (
 )
 
 // CreateProduct creates a new product persists data in the repository.
-func (uc *UseCase) CreateProduct(ctx context.Context, organizationID, ledgerID string, cpi *r.CreateProductInput) (*r.Product, error) {
+func (uc *UseCase) CreateProduct(ctx context.Context, organizationID, ledgerID uuid.UUID, cpi *r.CreateProductInput) (*r.Product, error) {
 	logger := mlog.NewLoggerFromContext(ctx)
 	logger.Infof("Trying to create product: %v", cpi)
 
@@ -28,15 +28,15 @@ func (uc *UseCase) CreateProduct(ctx context.Context, organizationID, ledgerID s
 
 	product := &r.Product{
 		ID:             uuid.New().String(),
-		LedgerID:       ledgerID,
-		OrganizationID: organizationID,
+		LedgerID:       ledgerID.String(),
+		OrganizationID: organizationID.String(),
 		Name:           cpi.Name,
 		Status:         status,
 		CreatedAt:      time.Now(),
 		UpdatedAt:      time.Now(),
 	}
 
-	_, err := uc.ProductRepo.FindByName(ctx, uuid.MustParse(organizationID), uuid.MustParse(ledgerID), cpi.Name)
+	_, err := uc.ProductRepo.FindByName(ctx, organizationID, ledgerID, cpi.Name)
 	if err != nil {
 		return nil, err
 	}