Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/MZ-574 #144

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Refactor/MZ-574 #144

merged 10 commits into from
Oct 22, 2024

Conversation

MartinezAvellan
Copy link
Member

@MartinezAvellan MartinezAvellan commented Oct 22, 2024 •
edited
Loading

Midaz Pull Request Checklist

Pull Request Type

  • Ledger
  • Auth
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@MartinezAvellan MartinezAvellan requested review from a team as code owners October 22, 2024 17:47
@MartinezAvellan MartinezAvellan changed the base branch from main to develop October 22, 2024 17:47
@MartinezAvellan MartinezAvellan changed the title Refactor/mz 574 Refactor/MZ-574 Oct 22, 2024
lfbarrile01
lfbarrile01 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@lfbarrile01 lfbarrile01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@MartinezAvellan MartinezAvellan merged commit adb7605 into develop Oct 22, 2024
13 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.23.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfbarrile01 lfbarrile01 lfbarrile01 approved these changes

@qnen qnen qnen approved these changes

@andrerussowsky andrerussowsky andrerussowsky approved these changes

@ClaraTersi ClaraTersi ClaraTersi approved these changes

Assignees
No one assigned
Labels
released on @develop released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinezAvellan @ClaraTersi @andrerussowsky @qnen @lfbarrile01