Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mz 450 #17

Merged
merged 42 commits into from
Jun 3, 2024
Merged

Feature/mz 450 #17

merged 42 commits into from
Jun 3, 2024

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Ledger
  • Auth
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

…thub.com/jackc/pgx/v5-5.6.0' into feature/MZ-450
@MartinezAvellan MartinezAvellan requested review from a team as code owners May 30, 2024 09:41
Copy link

what-the-diff bot commented May 30, 2024

PR Summary

  • Enhancements of Makefile:
    A new command make all-services has been incorporated into the Makefile.

  • Removal of Unused files:
    Several files under the mpostgresql directory were removed as part of an effort to clean up the codebase.

  • Improvements in Text Manipulation Functions:
    Two new functions RegexIgnoreAccents and RemoveChars have been introduced to the stringUtils.go file to handle string manipulations more efficiently.

  • The Creation of QueryHeader struct and ValidateParameters function:
    A new struct QueryHeader and a function ValidateParameters have been added in the utils.go file to make the validation of parameters more efficient.

  • Database Queries Optimization:
    Several files in the postgres and mongodb directories underwent changes. The main changes involve modification of the FindList and FindAll functions to accept parameters like limit and page to enhance paginated queries. In addition, the sqrl package will now be used for building SQL queries, improving readability, and maintenance.

  • Addition and modification in the organization.postgresql.go File:
    Many changes were made to the FindAll function to now accept limit and page arguments and use the sqrl package to construct the SQL query. A field tableName was also introduced into the structure.

  • Changes in the portfolio.postgresql.go File:
    This file was modified in the same vein, adapting the FindAll function to also use paginated search albeit with a few other changes.

  • Changes to GetAllInstruments, GetAllLedgers, etc:
    These functions now start to include a filter parameter, this functionality allows more specific searches, tailoring the results to fulfill user needs more suitably.

  • Overhaul of GetAllMetadata commands:
    The functions GetAllMetadataOrganizations, GetAllMetadataPortfolios, and GetAllMetadataProducts were adjusted to now accept a filter argument and disregard the previous arguments. This ensures that the functions can now be subject to more tailored information retrieval.

  • Database Interface Updates:
    A variety of Repository interfaces have been updated to include limit and page parameters to the FindAll function, facilitating paginated queries.

  • Alterations in mock.go Files:
    Several .go files had parameters added to the FindAll functions and import statements for common package were inserted where required.

  • CreateExtension SQL Migration files:
    Two new SQL migration files 000000_create_extension.up.sql and 000000_create_extension.down.sql were created.

  • Constraints added in SQL migrations:
    NOT NULL constraints were introduced to the id fields in several tables and their default value is now set as uuid_generate_v4().

  • Extension of Dependencies:
    Two more dependencies github.com/Masterminds/squirrel and github.com/lann/builder were appended to the go.mod file to facilitate construction and management of SQL queries.

  • Metadata and query parameters in API requests:
    Metadata and query parameters have been added to some API requests in the Postman collection to test the new functionalities.

Copy link
Contributor

@jeffersonrodrigues92 jeffersonrodrigues92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MartinezAvellan MartinezAvellan merged commit c12cebb into develop Jun 3, 2024
5 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.3.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants