Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/MZ-487 #24

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Fix/MZ-487 #24

merged 4 commits into from
Jun 4, 2024

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Ledger
  • Auth
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

@MartinezAvellan MartinezAvellan requested review from a team as code owners June 4, 2024 15:22
Copy link

what-the-diff bot commented Jun 4, 2024

PR Summary

  • Added new fields to ledger object
    In the file components/ledger/internal/app/command/create-ledger.go, two new fields, CreatedAt and UpdatedAt, were added to a data object known as ledger. This will enable the tracking of when data was first created and when it was last modified.

  • Updated ID field attribute
    In components/ledger/internal/domain/metadata/metadata.go, the ID field was updated with the omitempty attribute. This means that if the ID field is not provided or is null, it won't be included in the output.

  • Changed data type for entity_id
    In the SQL migration script components/ledger/migrations/000005_create_portfolio_table.up.sql, the data type for entity_id was changed from UUID to TEXT.

  • Updated Logs and Descriptions in Postman Collection
    Various console logs and descriptions related to field keys (organization_id, ledger_id, instrument_id, portfolio_id, product_id, account_id) were updated in the Postman file postman/MIDAZ.postman_collection.json. Repetitive updates were made to the descriptions of the metadata.chave and limit keys. These changes assist developers when testing API requests by providing more detailed information and explanations.

Copy link
Contributor

@jeffersonrodrigues92 jeffersonrodrigues92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MartinezAvellan MartinezAvellan self-assigned this Jun 4, 2024
@MartinezAvellan MartinezAvellan merged commit 8390ada into develop Jun 4, 2024
5 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.5.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants