Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/MZ-504 #32

Merged
merged 18 commits into from
Jun 5, 2024
Merged

Fix/MZ-504 #32

merged 18 commits into from
Jun 5, 2024

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Ledger
  • Auth
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

@MartinezAvellan MartinezAvellan requested review from a team as code owners June 5, 2024 17:37
Copy link

what-the-diff bot commented Jun 5, 2024

PR Summary

  • Improved Code Organization and HTTP Protocol Handling
    The queryHeader struct and validateParameters function have been moved from utils.go to the httputils.go file. This makes it easier to organize and find related functionalities in our codebase. Additionally, several new functions have been added such as GetFileFromHeader, GetRemoteAddress, and IPAddrFromRemoteAddr to enhance the HTTP protocol handling.

  • Refactoring of Function Argument Types
    A series of changes to the argument types of methods in various files, like get-all-accounts.go, get-all-instruments.go, get-all-ledgers.go and more, have been made from common.QueryHeader to commonHTTP.QueryHeader. This should help add consistency and uniformity to the codebase.

  • Addition of New Transaction Functions
    New functions related to transactions have been added in the 'transaction.go' file. These include CreateTransaction, CommitTransaction, RevertTransaction, and CreateTransactionTemplate which will help us to manage transactions better.

  • Added New HTTP Import Statements
    New import statements have been added in the files such as account.go, instrument.go, ledger.go and others to take advantage of utilities provided in the HTTP protocol module.

  • Introduction of InputDSL Structure
    An InputDSL structure has been introduced in transaction.go to improve the management of transaction data and ensure its integrity.

@MartinezAvellan MartinezAvellan merged commit 03f04b5 into develop Jun 5, 2024
5 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.8.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants