Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/MZ-429 #4

Merged
merged 2 commits into from
May 20, 2024
Merged

Fix/MZ-429 #4

merged 2 commits into from
May 20, 2024

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Ledger
  • Auth
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

@MartinezAvellan MartinezAvellan requested review from a team as code owners May 20, 2024 13:18
Copy link

what-the-diff bot commented May 20, 2024

PR Summary

  • Removal of Unnecessary Code in Ledger
    The programming tasks to convert the 'status' field format originally in 'ledger.postgresql.go' are no longer needed and are removed from 'Find' and 'FindAll' functions.

  • Improved Validation Checks in Organization Creation
    Adjustments have been made in 'create-organization.go', particularly in handling 'ParentOrganizationID'. Now, if this field is left blank, it's automatically set as non-applicable or empty.

  • Changes to 'ParentOrganizationID' Requirements
    In 'organization.go', ParentOrganizationID is now considered necessary when creating an organization. It's no longer marked as optional, meaning it has to be provided while using the CreateOrganizationInput structure.

Copy link
Contributor

@jeffersonrodrigues92 jeffersonrodrigues92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MartinezAvellan MartinezAvellan changed the title Fix/mz 429 Fix/MZ-429 May 20, 2024
@MartinezAvellan MartinezAvellan merged commit fd26b5f into develop May 20, 2024
5 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.1.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants