Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/MZ-435 #5

Merged
merged 2 commits into from
May 20, 2024
Merged

Fix/MZ-435 #5

merged 2 commits into from
May 20, 2024

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Ledger
  • Auth
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

@MartinezAvellan MartinezAvellan requested review from a team as code owners May 20, 2024 13:51
Copy link

what-the-diff bot commented May 20, 2024

PR Summary

  • Improvements to the Find operations
    The updates in components/ledger/internal/adapters/database/postgres/ledger.postgresql.go are focused on refining the Find and FindAll functions. These functions are now more efficient as they have eliminated certain operations related to the processing of the ledger.Status field.

  • Better handling of empty ParentOrganizationID
    The CreateOrganization function in components/ledger/internal/app/command/create-organization.go now has better handling for cases where ParentOrganizationID is left blank. This field will be set to null to prevent errors or confusion for such cases.

  • Stopping the unnecessary deletion of metadata
    Changes have been made to multiple Update functions, where previously if metadata was not present it was being unnecessarily removed. Now, we are retaining metadata in multiple components like accounts, instruments, ledger, organization, portfolio, and product. This updates are reflected in respective files, they are designed to make the system more data-rich and less volatile.

  • Refinement in Organization struct definitions
    In components/ledger/internal/domain/onboarding/organization/organization.go, the CreateOrganizationInput and UpdateOrganizationInput struct definitions have been honed. Now, the parentOrganizationId and metadata fields are no longer marked as optional, indicating a stronger requirement for these fields. This will ensure more complete data records in our organization-related functions.

Copy link
Contributor

@jeffersonrodrigues92 jeffersonrodrigues92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MartinezAvellan MartinezAvellan merged commit fb96e07 into develop May 20, 2024
5 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.1.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants