Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/MZ-297 #94

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Feature/MZ-297 #94

merged 2 commits into from
Oct 11, 2024

Conversation

andrerussowsky
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Ledger
  • Auth
  • Mdz
  • Transaction
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

@andrerussowsky andrerussowsky requested review from a team as code owners October 11, 2024 14:04
Copy link

what-the-diff bot commented Oct 11, 2024

PR Summary

  • Added Portfolio-based Operation Retrieval Function
    A new function FindAllByPortfolio was added to OperationPostgreSQLRepository to allow retrieval of operations using portfolio IDs. This change is crucial for enhancing portfolio tracking capabilities and simplifying data search.

  • Created Use Case for Fetching Operations using Portfolio ID
    A new file get-all-operations-portfolio.go has been included, containing the use case GetAllOperationsByPortfolio. This change utilizes the previously mentioned function to quickly fetch required data, resulting in more efficient operations and improved responsive time.

  • Test File for New Use Case
    A dedicated test file get-all-operations-portfolio_test.go has been created to test the new use case. Testing for success and error scenarios is vital for maintaining operational integrity and preventing potential issues.

  • Updated Repository Interface
    The Operation repository interface has been updated to include FindAllByPortfolio. This creates a consistent experience for developers and ensures compatibility with existing components.

  • Mock Repository Enhancement
    The mock repository was enhanced to support FindAllByPortfolio. This allows for thorough testing of the new functionality, ensuring its reliability and stability during use.

  • New HTTP GET Endpoint for Operations Retrieval
    The routes file has been modified to include a new HTTP GET endpoint, improving data retrieval capabilities for client-side applications.

  • New Request Handling Method in OperationHandler
    A new method GetAllOperationsByPortfolio has been added to OperationHandler to handle incoming requests routed to the new endpoint, offering an optimized approach to process such requests.

  • Improved Code Readability
    Some variable names in GetAllOperationsByAccount method have been made more descriptive, improving code legibility, and making the codebase easier to adopt by other developers.

Copy link
Contributor

@lfbarrile01 lfbarrile01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@MartinezAvellan MartinezAvellan merged commit 6fc09c5 into develop Oct 11, 2024
5 checks passed
@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.15.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lerian-studio-midaz-push-bot
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants